search

alpheios-project / alpheios-core

Alpheios Core Javascript Packages and Libraries
15 stars 2 forks source link

tokenization adapter misses the 'ignore' option for the tei endpoint #587

Closed balmas closed 3 years ago

balmas commented 3 years ago

reported by @monzug

The 'ignore' option if supplied in the parameters to the tokenize adapter fetchOptions does not get passed on to the service.

I think it would be better if the adapter did not hard code the option names, but instead retrieved them from the service schema.

monzug commented 3 years ago

similar behavior with Supply a comma-separated list of elements in the text that represent visual blocks I added "l,p" to the list and compare with an empty list, (removed all the elements), the line breaks in the alignment looked the same. I did also try with 'div". the origin and target text had l,p and div tags.

irina060981 commented 3 years ago

Merged and closed

monzug commented 3 years ago

Supply a comma-separated list of elements in the text that represent visual blocks works now. tested with l, p and div.