search

alpheios-project / alpheios-core

Alpheios Core Javascript Packages and Libraries
15 stars 2 forks source link

Multiple popups opened simultaneously #663

Closed irina060981 closed 2 years ago

irina060981 commented 2 years ago

I also got multiple popups opened simultaneously (occasionally) in the Latin pages. Screen Shot 2021-11-17 at 1 55 18 PM

Originally posted by @monzug in https://github.com/alpheios-project/alpheios-core/issues/622#issuecomment-971543748

irina060981 commented 2 years ago

I believe that it was caused bu another bug in webextension. Now it should be fixed in new Release https://github.com/alpheios-project/webextension/releases

monzug commented 2 years ago

tested in FF/PC in build Alpheios Reading Tools 3.4.1 build incr-3.4.x.20211118345 Alpheios Components 3.3.3-incr-3.4.x.20211116233 build i662-lexical-dicts.20211118457

I haven't seen the 3 pop-ups opened simultaneously in latest build but I still see more than one pop-up. see below diffidere

irina060981 commented 2 years ago

Will try to reproduce

irina060981 commented 2 years ago

I am sorry, Monica, but I could not reproduce it in a new build (I saw it before my last changes).

So - if you still could reproduce it (from the latest build - be sure, that you clear previous build), I need detailed steps.

Previously these bug was because extension was attached several times (on page reload, on moving tab, on rechoosing tab). That's why several popups was rendered at a time.

But now I could not reproduce several attachments, that's why I don't see any possibility to have more than one popup. Waiting for steps from you.

monzug commented 2 years ago

I reinstall FF and latest alpheios build. I do not see any double pop-ups anymore. great