search

alpheios-project / alpheios_nemo_ui

Alpheios Reader
https://texts.alpheios.net
GNU General Public License v3.0
3 stars 0 forks source link

hide embedded library notice in alpheios_nemo_ui #272

Closed balmas closed 5 years ago

balmas commented 5 years ago

@monzug reports receiving the embedded library notice in the texts environment:

Screen Shot 2019-08-13 at 4 04 19 PM

Need to review the situations under which this occurs and decide if we want to keep it or not.

balmas commented 5 years ago

the embedded lib active notice was implemented in 2.1.0.x as part of this issue:

https://github.com/alpheios-project/webextension/issues/176 to deal with the timing issue in Safari which @kirlat explained so helpfully here:

https://github.com/alpheios-project/embed-lib/issues/27#issuecomment-446552969

balmas commented 5 years ago

sadly, the I did not follow up on my comment in alpheios-project/embed-lib#27 about needing to make sure this was addressed in this release...

I think we need to tackle this with the next big release but not for the Safari release. As of right now, the number of sites using the embedded library is very small, and we are not actively promoting our own pages. This will change going forward and we do need to address it one way or another, but I do not want to hold the 2.1.0.x release for it to work perfectly.

balmas commented 5 years ago

That said, I think that there still isn't a huge amount we can do here. I am thinking we do NOT want to display the notice on the Alpheios Reader though, because it would just add confusion to the user. So I am leaning towards just hiding the notice there, but leaving it for other uses of the embed-lib, but with updated branding colors.

@monzug what do you think?

monzug commented 5 years ago

after all it's not a misleading message so we can live with it for now.

balmas commented 5 years ago

the notice actually already has been updated with the new colors and fonts, so we just need to hide it nemo.

balmas commented 5 years ago

I'm not sure it's really going to be possible to test this one, since you're looking for the negative ... i.e. you should not get the embedded library notice in the texts environment anymore. It will be there (if the circumstances are right for the touchy Safari browser) for 3rd party sites, but I'll have to set one up for you to test that. So keeping myself assigned as well.

monzug commented 5 years ago

well, I tried reloading and activating the icon, also switching from one site deactivate alpheios and activate again and then going to the text env. Didn't see the message. close this one for the moment. in case I see the msg I will reopen this issue.