search

alpheios-project / alpheios_nemo_ui

Alpheios Reader
https://texts.alpheios.net
GNU General Public License v3.0
3 stars 0 forks source link

De bello gallico: Find passage shows the Commentarius #279

Closed monzug closed 5 years ago

monzug commented 5 years ago

If I enter 4 in Find passage, it will show the COMMENTARIUS QUARTUS, which corresponds to Chapter 4 without the Chapters. in the TOC, the books are separated in chapters. I don't mind to have the two options but it can be confusing. Is this intentional?

monzug commented 5 years ago

also, Amores by Ovid and Elegiae by Propertius maybe it would be nice if we change TOC display int this way. if I click on the book, then we display the entire book with no passages/chapter etc, if we click on the arrow next to the book, we display the book with the separation. what do you think?

balmas commented 5 years ago

I think that's a good idea and a simple solution for a complex problem.

irina060981 commented 5 years ago

maybe it would be nice if we change TOC display int this way. if I click on the book, then we display the entire book with no passages/chapter etc, if we click on the arrow next to the book, we display the book with the separation

I am not sure - I have correctly understand

image

So if we click on the word Book1 - we should open the start of the first chapter of the first book, the following: image

If we click on the arrow next to the book, then we should open the references: image

Am I right?

monzug commented 5 years ago

Irina, do the following: go to any passage of de bello gallico, then in find passage, enter 1. You’ll see the the book has no separation in chapters and the book title is Commentarius primus. Now enter 1.1 in find passage and you’ll see that the book is separated in passages. Do you see the difference with the two actions?

Sent from my iPhone

On 27 Aug 2019, at 07:23, Sklyarova Irina notifications@github.com wrote:

maybe it would be nice if we change TOC display int this way. if I click on the book, then we display the entire book with no passages/chapter etc, if we click on the arrow next to the book, we display the book with the separation

I am not sure - I have correctly understand

So if we click on the word Book1 - we should open the start of the first chapter of the first book, the following:

If we click on the arrow next to the book, then we should open the references:

Am I right?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

monzug commented 5 years ago

So, from TOC if i click on Book 1 I should see same as the result of find passage 1.

Sent from my iPhone

On 27 Aug 2019, at 08:38, Monica Zugan monzug@gmail.com wrote:

Irina, do the following: go to any passage of de bello gallico, then in find passage, enter 1. You’ll see the the book has no separation in chapters and the book title is Commentarius primus. Now enter 1.1 in find passage and you’ll see that the book is separated in passages. Do you see the difference with the two actions?

Sent from my iPhone

On 27 Aug 2019, at 07:23, Sklyarova Irina notifications@github.com wrote:

maybe it would be nice if we change TOC display int this way. if I click on the book, then we display the entire book with no passages/chapter etc, if we click on the arrow next to the book, we display the book with the separation

I am not sure - I have correctly understand

So if we click on the word Book1 - we should open the start of the first chapter of the first book, the following:

If we click on the arrow next to the book, then we should open the references:

Am I right?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

irina060981 commented 5 years ago

ok, I see - thank you, @monzug :)

irina060981 commented 5 years ago

Would be this way

image

Click on the Poem1 image

Click on the arrow image

image

Click on the Book1 image

Click on the arrow image

Click on the chapter1 or on the arrow image

balmas commented 5 years ago

yes.

monzug commented 5 years ago

Thanks!

On Tue, Aug 27, 2019 at 1:14 PM Bridget Almas notifications@github.com wrote:

yes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/alpheios_nemo_ui/issues/279?email_source=notifications&email_token=AJ32UOMZGKWJGJM2BACETEDQGUECZA5CNFSM4IPNLDOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5HMILA#issuecomment-525255724, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ32UON3YNNZQ7TMDTXTYLDQGUECZANCNFSM4IPNLDOA .

irina060981 commented 5 years ago

Finally it has the following behaviour

Merged and closed

monzug commented 5 years ago

looks good to me. Thanks