alpheios-project / alpheios_nemo_ui

Alpheios Reader
https://texts.alpheios.net
GNU General Public License v3.0
3 stars 0 forks source link

Fix references - books, chapters, passages #283

Closed irina060981 closed 5 years ago

irina060981 commented 5 years ago

For the issue - https://github.com/alpheios-project/alpheios_nemo_ui/issues/279

Would be this way

image

Click on the Poem1 image

Click on the arrow image

image

Click on the Book1 image

Click on the arrow image

Click on the chapter1 or on the arrow image

irina060981 commented 5 years ago

@balmas , my first variant was exactlu as you described, but it failed on the chapters level - because we have human_reff|i18n_citation_item not equal the second level format as 1.1 or 2.1. They are also 1, 2 and so on

And the link will be constructed similiar to books - and would lead to the book with the same number, but not to the chapter.

That's why I have added this additional condition.

balmas commented 5 years ago

Ah, yes you are right about that. Ok, then I'd like to propose the change in b5ec5f0 which builds the subreference link up from the previous link. That will allow for 3 level citation schemes other than book/chapter/passage. What do you think?

irina060981 commented 5 years ago

@balmas , then we have 3 variants of layout

Is it a consistent behaviour?

balmas commented 5 years ago

yes, that's the correct behavior.

irina060981 commented 5 years ago

Then I think, I could merge it?

balmas commented 5 years ago

yes please :-D