search

alpheios-project / alpheios_nemo_ui

Alpheios Reader
https://texts.alpheios.net
GNU General Public License v3.0
3 stars 0 forks source link

Issue 302 #303

Closed balmas closed 5 years ago

balmas commented 5 years ago

I was hoping to leave any existing alpheios_nemo_ui session and login intact, but it seems that signing up for a new account will invalidate your existing Auth0 session, even if the configuration is setup to not log the user in automatically after signup.

Going along with this change were changes to the Universal Login form on Auth0, to set the following parameters if the mode==='signUp':

allowLogin: config.extraParams.mode === 'signUp' ? false : true,
loginAfterSignUp: config.extraParams.mode == 'signUp'? false : true

allowLogin prevents the display of the login form loginAfterSignUp prevents automatic login after signup

If/when we end up doing a non-safari specific sign route we will need to change this, so that we get different behavior for the different applications (i.e. for the webextension and the text environment we would probably want to allow login from signup) but this should be okay for now.

balmas commented 5 years ago

@kirlat I am going to merge this so that it's available for you to test/develop with. Let me know if you see problems with it though.

kirlat commented 5 years ago

 I've checked it and it looks good to me