search

alpheios-project / arethusa-configs

Additional configuration files for Arethusa
0 stars 9 forks source link

Check in dist files #76

Closed zfletch closed 4 years ago

zfletch commented 4 years ago

Based on the discussion in https://github.com/alpheios-project/arethusa-configs/pull/75, run bundle exec rake build and check in all the files.

These changes match the files currently hosted by Perseids.

zfletch commented 4 years ago

@balmas I think we should make sure that when someone makes a pull request, we update the dist/ files. This seems to me like the best solution since pull requests are fairly infrequent and it simplifies deployment.

If it turns out that pull requests are frequent, I would argue for adding dist/ to .gitignore. Checking in dist/ but having it be incorrect (like it was previously) seems like it could lead to a lot of accidental bugs.