search

alpheios-project / arethusa

Arethusa: Annotation Environment
http://sosol.perseids.org/tools/arethusa
MIT License
34 stars 26 forks source link

Use configuration for externalDependencies #753

Open fbaumgardt opened 8 years ago

fbaumgardt commented 8 years ago

The locations for modules' JS dependencies are hardcoded in the externalDependencies property, read by the plugins module and subsequently loaded. This breaks when using Arethusa as a plugin, we can

a) hardcode CDN locations b) move the locations into the config files

I'd prefer b), but have to check the timeline during init to see if config is available during loading time of externalDependencies.

PonteIneptique commented 8 years ago

I think it's quite important for dagre :)

fbaumgardt commented 8 years ago

Yep! The issue was that this specific version was not available on CDN and so I linked a local copy. Sorry, forgot about the hardcode! :\

Am 08.06.2016 um 05:43 schrieb Thibault Clérice notifications@github.com:

I think it's quite important for dagre :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/arethusa/issues/753#issuecomment-224540697, or mute the thread https://github.com/notifications/unsubscribe/AAhw3-2zSZuIQ_IWSd4Z8AKpBVY2NmlWks5qJo7PgaJpZM4IeVXz.

PonteIneptique commented 8 years ago

The only two I had to rewrite were i18n and dagre : 

window.i18npath = "{{url_for(".r_arethusa_assets", filename="i18n/")}}";
window.dagred3path = "vendor/dagre-d3.min.js";