search

alpheios-project / arethusa

Arethusa: Annotation Environment
http://sosol.perseids.org/tools/arethusa
MIT License
34 stars 26 forks source link

Issue #761 : Namespace Arethusa CSS #762

Open PonteIneptique opened 8 years ago

PonteIneptique commented 8 years ago

Fix for #761 : I chose the class .__artsa to minimize collision. Now, if arethusa is installed somewhere else, we need to remember to add this class :) If I should add this in some doc, please tell me.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 43.174% when pulling 40aa835b7a98f7a1ad2ba6e0db8901aeb63d8fb5 on issue-761 into 1cd0320d21dec59dcbf67bd06d7bd5fab3aa7e8c on master.

balmas commented 8 years ago

@fbaumgardt can you review? Thanks!

fbaumgardt commented 8 years ago

@PonteIneptique @balmas Sorry for the slow response, first I had issues with a clean build, because of out-of-sync dependencies; then I tried to figure out whether the CSS issues I am seeing are due to anything in my setup. If that's the case I have not found the offender yet. Have you tried running this from a fresh build, any issues?

I get this screen upon pageload and when I resize it behaves erratically, i.e. the arethusa canvas resizes beyond the edge of the viewport. bildschirmfoto 2016-06-17 um 09 56 25

PonteIneptique commented 8 years ago

Hmm. Probably means the namespacing I added should have been applied on the whole document. Could you try adding the namespace class to the html document (if it is even possible to do so...)

balmas commented 8 years ago

I think the namespacing might also need a little refinement --- when I did it I noticed some things getting namespaced in a way wasn't quite right, e.g.

.arethusa html .arethusa body

fbaumgardt commented 8 years ago

That helped with some of the missing style attributes but the canvas size issue remains.

Am 17.06.2016 um 10:09 schrieb Thibault Clérice notifications@github.com:

Hmm. Probably means the namespacing I added should have been applied on the whole document. Could you try adding the namespace class to the html document (if it is even possible to do so...)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/arethusa/pull/762#issuecomment-226778654, or mute the thread https://github.com/notifications/unsubscribe/AAhw3-C8vF__OMh10RDchC_ZbxRuoZxCks5qMqqUgaJpZM4Iwxuh.