search

alpheios-project / arethusa

Arethusa: Annotation Environment
http://sosol.perseids.org/tools/arethusa
MIT License
34 stars 26 forks source link

option to exclude unusedSelector and unusedHighlighter from display #816

Closed balmas closed 4 years ago

balmas commented 4 years ago

in a read-only widget view, the unusedSelector and unusedHighlighter don't really add any value. It would be nice to be able to optionally remove these from the display

balmas commented 4 years ago

This is fixed and deployed in https://github.com/perseids-tools/arethusa-widget/releases/tag/v2.1.0 which is now live at trees.alpheios.net. The fix can be verified with any of the treebanked texts at texts.alpheios.net

balmas commented 4 years ago

this apparently caused the problems in #820 so reopening for another look

balmas commented 4 years ago

To retest with #820

balmas commented 4 years ago

this is fixed now but need to wait for alpheios-project/alpheios-core#523 to be fixed to test in texts-test.

balmas commented 4 years ago

test in texts-test.alpheios.net

Alpheios Embedded Library 3.3.0-qa.20200813461 Alpheios Components 3.3.0-qa.20200813570

Please test with a variety of panel sizes and tree sizes.

monzug commented 4 years ago

We still have some overflow when zooming in Arethusa. and few shots of Alpheios treebank (Chrome/PC, not in FF). @balmas?

zoming-treebank

alpheios-treebank-2

alpheios-treebank

monzug commented 4 years ago

Chrome/Mac

Screen Shot 2020-08-14 at 4 25 03 PM

Screen Shot 2020-08-14 at 4 25 19 PM

balmas commented 4 years ago

hmm. that's interesting. Can you clear your cache and try again just to be sure?

I was able to reproduce with the prior version of the code but cannot now (in Chrome on Linux).

In any event, I think I can live with it. What about you?

monzug commented 4 years ago

I clear my cache before opening the texts site. I'll do it again (unless there is again a problem with having the extension open on a tab)

On Fri, Aug 14, 2020 at 10:39 AM Bridget Almas notifications@github.com wrote:

hmm. that's interesting. Can you clear your cache and try again just to be sure?

I was able to reproduce with the prior version of the code but cannot now (in Chrome on Linux).

In any event, I think I can live with it. What about you?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/arethusa/issues/816#issuecomment-674106538, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOI572E7IIQCRJJCMXTSAVEARANCNFSM4OCCCOBQ .

monzug commented 4 years ago

it's still a little off but we can leave as is

On Fri, Aug 14, 2020 at 11:02 AM Monica Zugan monzug@gmail.com wrote:

I clear my cache before opening the texts site. I'll do it again (unless there is again a problem with having the extension open on a tab)

On Fri, Aug 14, 2020 at 10:39 AM Bridget Almas notifications@github.com wrote:

hmm. that's interesting. Can you clear your cache and try again just to be sure?

I was able to reproduce with the prior version of the code but cannot now (in Chrome on Linux).

In any event, I think I can live with it. What about you?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/arethusa/issues/816#issuecomment-674106538, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOI572E7IIQCRJJCMXTSAVEARANCNFSM4OCCCOBQ .

monzug commented 4 years ago

new-alpheios-treebank