search

alpheios-project / arethusa

Arethusa: Annotation Environment
http://sosol.perseids.org/tools/arethusa
MIT License
34 stars 26 forks source link

Tree overflow with dep_tree_no_selector template. #820

Closed zfletch closed 4 years ago

zfletch commented 4 years ago

This looks like a bug introduced in https://github.com/alpheios-project/arethusa/pull/818

When the depTree template is js/templates/dep_tree_no_selector.html, the tree bounds checking doesn't work and the tree can overflow on the bottom up to around 25px. There is also an extra gap at the top. (It also looks like there's a 1 or 2 pixel overflow in the dep_tree.html template. I think this is worth fixing, but it's a much smaller issue and isn't really noticeable unless zoomed in).

No selector (bottom):

dep_tree_no_selector

No selector (top):

dep_tree_no_selector_top

Selector:

dep_tree
balmas commented 4 years ago

oh shoot sorry about that. I will take a look as soon as I can. In the meantime, feel free to revert back to the other template.