search

alpheios-project / embed-lib

Alpheios Embedded Library
Other
6 stars 0 forks source link

Fix skinning document (to the current components state) #93

Closed irina060981 closed 5 years ago

irina060981 commented 5 years ago

For the issue https://github.com/alpheios-project/embed-lib/issues/84

irina060981 commented 5 years ago

I will answer here :)

It is because we use color's variables here instead of some aliases.

We are not publishing colors to the developers documentation. If we publish colors variables too here, than we suggest developers to change values for alpheios colors variables - and it could lead to a complete chaos in styles.

I believe that we publish only those variables, that we suggest to override. Of course the better way would be to create skin aliases or set some existed skin variables, for example --alpheios-definition-short-color | --alpheios-color-dark to --alpheios-definition-short-color | --alpheios-text-color-dark

It would have sense by default and could be easily customizable. But as we decide to change only docs, then I did it this way.

What do you think about my arguments, @balmas ?

balmas commented 5 years ago

ok, i think you make a very clear argument @irina060981 :-) Please go ahead and merge.