Back to index in the Allen's grammar very slow (sometimes)

[monzug]

I did experience the Back to Index slowness today again (May 6, 2020). Actually at one point it just did not do anything, while the language selector worked well. I had to close and reopen the grammar. As I had to check links to different sections of the conjugation chapter, I did use back to index heavily before it just stopped working.

[balmas]

@irina060981 can you spend a little time investigating this? As the main page should be cached, the only thing I can think of is that perhaps Vue isn't picking up on the fact that the url changed when "back to Index" is clicked. We previously had problems with this when we didn't use a hash reference in the index url, although I don't know if we ever understood why that was and I just fixed the urls to workaround it. See alpheios-project/components#837

[irina060981]

As I could see we have here another problem - lots of grammar pages have hidden youtube player inside iframe:

and this block uploads a lot of additional js libs

and not all of them could be cached

So I believe that we could have some delays on clicking Back to Index, because it has busy queue with youtube files. This youtube player is set as display: none

@balmas and @monzug , we could remove it from the source and it would make pages lighter?

[monzug]

the idea is that we might want to use thee videos at one point, that's why they are commented out.

On Tue, May 12, 2020 at 12:33 AM Sklyarova Irina notifications@github.com wrote:

As I could see we have here another problem - lots of grammar pages have hidden youtube player inside iframe: [image: image] https://user-images.githubusercontent.com/12377640/81633446-1fcc5200-9450-11ea-853a-a6be05a7f89a.png

and this block uploads a lot of additional js libs [image: image] https://user-images.githubusercontent.com/12377640/81633488-38d50300-9450-11ea-9b33-3954743600ba.png

and not all of them could be cached

So I believe that we could have some delays on clicking Back to Index, because it has busy queue with youtube files. This youtube player is set as display: none

@balmas https://github.com/balmas and @monzug https://github.com/monzug , we could remove it from the source and it would make pages lighter?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/alpheios-core/issues/305#issuecomment-627101767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOL3V6ZNL4I3XYURKM3RRDGPZANCNFSM4M2TGBQA .

[balmas]

Hmm. I didn't think about the fact that the browser would still try to load them even though they are hidden. That's a good point. I think I can convert them to comments rather than using CSS to hide them. That will allow us to keep them in there but should prevent the browser from trying to load them. I'll work on that. Thanks.

[monzug]

good point.

On Tue, May 12, 2020 at 8:30 AM Bridget Almas notifications@github.com wrote:

Hmm. I didn't think about the fact that the browser would still try to load them even though they are hidden. That's a good point. I think I can convert them to comments rather than using CSS to hide them. That will allow us to keep them in there but should prevent the browser from trying to load them. I'll work on that. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/alpheios-core/issues/305#issuecomment-627312295, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOIRXSCD7NOAXYDW3HTRRE6MVANCNFSM4M2TGBQA .

[balmas]

ok, I commented out all the video iframes. Curious to know if it makes any difference.

[monzug]

I used it quite a bit today and I had no issues. good point, Irina.