alpheios-project / inflection-games

There is a repo for inflection games
GNU General Public License v3.0
0 stars 0 forks source link

first glance at the games functionality #3

Open monzug opened 6 years ago

monzug commented 6 years ago

1) design: can we add more space between Lexemes data and Games variants in the first pop-up? it looks a little crowded. 2) the Hide button next to Games variants does not seem to work. 3) design: would it be possible to make more clear what to click to start the game in Games variants section (first pop-up)? 4) amens is an adj of the 3rd decl. However, declension is not an option to select in the games. why? 5) it seems that when there are several lemmas for a word, the yellow highlighting goes to the one that has no meaning or no morphology or less common. e.g. deos (yellow is deus with no definition found) or magis (yellow is adverb, not the noun) or me (see attached screenshot) 6) going back to deos, in whitaker is 2nd declension de.os N 2 1 ACC P M
Deus, Dei N M [XEXAO]
God (Christian text); god; divine essence/being, supreme being; statue of god; in the game is 4th declension. where is this coming from? 7) design: can we suppress the Games button for pronoun, conjunction etc? 8) at one point, I had: made clicks 7, max clicks 6.... etc - what is the functionality of max clicks, then? 9) design: can we add a reset button to stop counting success, failed etc? 10) Cynthia is not highlighted in yellow in the morphology pop-up. 11) design: I would suggest to have a game with two options: 1) same as what we have now, 2) remove the declension, gender etc from the morphology pop-up so the user can really test his/her knowledge. Out of scope, right? 12) not sure why the yellow highlighted is sticky after clicking on a word. is this by design? see screenshot screenshot_2018-10-11 alpheios sextus propertius elegies 1

balmas commented 6 years ago

A few quick comments

balmas commented 6 years ago

Re # 11 , nothing really is out of scope right now ,the whole point of this exercise is to figure out what might be in scope :-)

Exactly how the use of the games should or shouldn't interact with the rest of the interface is up for discussion!

monzug commented 6 years ago

an other thing that I have notice: when I close the game pop-up and move the focus back to the morphology pop-up, the backscreen slides up few rows. tested on firefox

irina060981 commented 6 years ago

Hello, @monzug and @balmas!

Monica, thank you for finding time to look at the games! My answers:

1) design: can we add more space between Lexemes data and Games variants in the first pop-up? it looks a little crowded I have tried to make as near as possible - to stay more space for the table. But If you think - it is too near - I will add space.

2) the Hide button next to Games variants does not seem to work. there is a condtion there - that it could be hidden only after you have selected one. I will hide hide button if no game is selected - if it seems as it doesn't work

3) design: would it be possible to make more clear what to click to start the game in Games variants section (first pop-up)? Ok, I will add - select a game instead of Game Variants

4) amens is an adj of the 3rd decl. However, declension is not an option to select in the games. why? What do you mean here? It the first in the Features List: image How could I reproduce the absence of declension?

5) Yellow highliting - it is for alignment property and diambiguated lemmas - not for games

6) going back to deos, in whitaker is 2nd declension. in the game is 4th declension. where is this coming from? I don't see 4th declension here - could say me steps to reproduce? image

7) design: can we suppress the Games button for pronoun, conjunction etc? Yes I will fix it

8) at one point, I had: made clicks 7, max clicks 6.... etc - what is the functionality of max clicks, then? From my point of view it means that you could make 6 clicks and the 7th will be the last ... if it is confusing - I will fix it - and the 6th will be the last (I don't remember the steps I was deciding how to handle with clicks now, but your question is saying - that my decision is not natural :) )

9) design: can we add a reset button to stop counting success, failed etc? It is an interesting suggestion - I will add, thanks, Monica!

10) Yellow highliting - it is for alignment property and diambiguated lemmas - not for games

11) design: I would suggest to have a game with two options: 1) same as what we have now, 2) remove the declension, gender etc from the morphology pop-up so the user can really test his/her knowledge. Out of scope, right? Now, it is not difficult to add such an option really, I will add it - need to think only how to organize the UI for this (it is so less space .... :) )

12) sticking and scrolling up - it is for lignment functionality - browser tries to show latin and aligning translation - but it is not for games

Ok, I have pointed what I could make on the next week and also I left some questions in the list, hope, you will give me some more explanations on it :)

monzug commented 6 years ago

Irina, thanks for the reply. are we using the same build? I was able to reproduce the missing declension for amens see screenshots

image

monzug commented 6 years ago

here is the screenshot for deos of 4th decl deos

irina060981 commented 6 years ago

Screenshots from Monica

image

image

irina060981 commented 6 years ago

Hello, Monica (@monzug )! I am using 2 resources 1) http://www-test.alpheios.net/alpheios-texts/Perseus.text.1999.02.0066/book1_poem1.html This resouce as with build for testing was given to me by @balmas

amens image

deos image

2) http://alpheios-test4.irina-sklyarova.ru/Perseus.text.1999.02.0066/book1_poem2.html This is a testing copy on my server - where I am testing my changes The both resources has the same results (as on screenshots)

monzug commented 6 years ago

Good morning Irina, Bridget made a new build on Friday but I haven't had time to look at it yet. I have the feeling that we are not in sync.

On Mon, Oct 15, 2018 at 3:06 AM Sklyarova Irina notifications@github.com wrote:

Hello, Monica (@monzug https://github.com/monzug )! I am using 2 resources

1. http://www-test.alpheios.net/alpheios-texts/Perseus.text.1999.02.0066/book1_poem1.html This resouce as with build for testing was given to me by @balmas https://github.com/balmas

amens [image: image] https://user-images.githubusercontent.com/12377640/46934738-36f06580-d09c-11e8-91a8-df3a9b63605d.png

deos [image: image] https://user-images.githubusercontent.com/12377640/46934805-78811080-d09c-11e8-93c0-094a4374bf55.png

1. http://alpheios-test4.irina-sklyarova.ru/Perseus.text.1999.02.0066/book1_poem2.html This is a testing copy on my server - where I am testing my changes The both resources has the same results (as on screenshots)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/inflection-games/issues/3#issuecomment-429731445, or mute the thread https://github.com/notifications/unsubscribe-auth/AneqOTDaUWxai0oaj0tMnRN3BEy1Nxavks5ulDPvgaJpZM4XXrXT .

irina060981 commented 6 years ago

Monica, it is really strange! Because I couldn't imagine how it could be realized these differences if declension is missing for amens in your case - it seems that the inflection game table differs too.

If the game table differs for amens and deos than it could mean that inflection tables differs on different builds, because I am coping it to games or there are some wonders here ...

Could you check in you build - if inflection tables are correct for these words?

monzug commented 6 years ago

Interesting. so, the morphology panel does say that amens is an adj 3rd decl sing nom. masc. I double check the translation and it's correct to be masc. not sure bout the diagram. in the inflection table, both - endings for 1st/2nd decl and 3rd decl are highlighted. so somehow it didn't get the information that it's only 3rd decl. I am going to try on Bridget's latest build

On Mon, Oct 15, 2018 at 4:41 AM Sklyarova Irina notifications@github.com wrote:

Monica, it is really strange! Because I couldn't imagine how it could be realized these differences if declension is missing for amens in your case - it seems that the inflection game table differs too.

If the game table differs for amens and deos than it could mean that inflection tables differs on different builds, because I am coping it to games or there are some wonders here ...

Could you check in you build - if inflection tables are correct for these words?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/inflection-games/issues/3#issuecomment-429757743, or mute the thread https://github.com/notifications/unsubscribe-auth/AneqOcn3FrBQZWun2-EY2Z2jmQWaF2aiks5ulEpCgaJpZM4XXrXT .

monzug commented 6 years ago

in the case of deos, the scenario is different. we have two definition for deos and the game is set for the less common word which does not have the declension. I have compared the result with Whitaker and the second definition (the less common one) does not exist. in the inflection table, all the matching ending for deos (2nd decl nom and acc and 4th decl acc) are highlighted. could it be that declension information for deos is coming from matching the endings???? two things here: 1) the less common word is selected 2) based on the partial information on this word, the declension is chosen by the matching

On Mon, Oct 15, 2018 at 7:21 AM Monica Zugan monzug@gmail.com wrote:

Interesting. so, the morphology panel does say that amens is an adj 3rd decl sing nom. masc. I double check the translation and it's correct to be masc. not sure bout the diagram. in the inflection table, both - endings for 1st/2nd decl and 3rd decl are highlighted. so somehow it didn't get the information that it's only 3rd decl. I am going to try on Bridget's latest build

On Mon, Oct 15, 2018 at 4:41 AM Sklyarova Irina notifications@github.com wrote:

Monica, it is really strange! Because I couldn't imagine how it could be realized these differences if declension is missing for amens in your case - it seems that the inflection game table differs too.

If the game table differs for amens and deos than it could mean that inflection tables differs on different builds, because I am coping it to games or there are some wonders here ...

Could you check in you build - if inflection tables are correct for these words?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/inflection-games/issues/3#issuecomment-429757743, or mute the thread https://github.com/notifications/unsubscribe-auth/AneqOcn3FrBQZWun2-EY2Z2jmQWaF2aiks5ulEpCgaJpZM4XXrXT .

monzug commented 6 years ago

ok. I figured out what's going on here. I do click on amens and then from the morphology pop-up, I click on the Games button and the scenario is the one from screenshot above with no declension in the game. if I click on Games from the lookup for amens (with no diagram involved) the scenario is the one that Irina has reported (with the declension in the game). still in both games, I am not able to fail a game, they all end up with success at the 7th click

On Mon, Oct 15, 2018 at 8:14 AM Monica Zugan monzug@gmail.com wrote:

in the case of deos, the scenario is different. we have two definition for deos and the game is set for the less common word which does not have the declension. I have compared the result with Whitaker and the second definition (the less common one) does not exist. in the inflection table, all the matching ending for deos (2nd decl nom and acc and 4th decl acc) are highlighted. could it be that declension information for deos is coming from matching the endings???? two things here: 1) the less common word is selected 2) based on the partial information on this word, the declension is chosen by the matching

On Mon, Oct 15, 2018 at 7:21 AM Monica Zugan monzug@gmail.com wrote:

Interesting. so, the morphology panel does say that amens is an adj 3rd decl sing nom. masc. I double check the translation and it's correct to be masc. not sure bout the diagram. in the inflection table, both - endings for 1st/2nd decl and 3rd decl are highlighted. so somehow it didn't get the information that it's only 3rd decl. I am going to try on Bridget's latest build

On Mon, Oct 15, 2018 at 4:41 AM Sklyarova Irina notifications@github.com wrote:

Monica, it is really strange! Because I couldn't imagine how it could be realized these differences if declension is missing for amens in your case - it seems that the inflection game table differs too.

If the game table differs for amens and deos than it could mean that inflection tables differs on different builds, because I am coping it to games or there are some wonders here ...

Could you check in you build - if inflection tables are correct for these words?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/inflection-games/issues/3#issuecomment-429757743, or mute the thread https://github.com/notifications/unsubscribe-auth/AneqOcn3FrBQZWun2-EY2Z2jmQWaF2aiks5ulEpCgaJpZM4XXrXT .

irina060981 commented 6 years ago

Monica, thank you for all this investigation!

I was all in adding changes to the code from the above list (I have added them - 1, 2, 3, 7, 8, 9, 11). now the window for games looks like this: (not hard mode) image

(hard mode) image

PR here: https://github.com/alpheios-project/inflection-games/pull/6

Changes here: https://github.com/alpheios-project/components/tree/infl-games

Rebuild and recompile here: https://github.com/alpheios-project/embed-lib/tree/inflection-games

irina060981 commented 6 years ago

@monzug, great, now I know how to try reproduce it, thanks!

About amens and deos - I haven't been able to find it in the text - so I was only looked it up. So I will find it in the text and test.

About always successful - if to be honest if to click in the table - I am always failing :) If to click on features - than it is really easy to win :)

Ok - I will work on such strange bahaviour with disambiguated words and also I have found several bugs more. Again, Monica, thank you for your attentiveness!

irina060981 commented 6 years ago

@balmas, thank you for merging embedded for inflection-games - I have failed to merge it quickly myself and then found out - that you had already done it!

balmas commented 6 years ago

ok. I figured out what's going on here. I do click on amens and then from the morphology pop-up, I click on the Games button and the scenario is the one from screenshot above with no declension in the game. if I click on Games from the lookup for amens (with no diagram involved) the scenario is the one that Irina has reported (with the declension in the game).

Ah ok, this is interesting. It means that something is wrong with the disambiguation. Declension is not provided in the treebank data, but the disamibugation is supposed to merge that data with the parser results without losing anything. But it would seem that is not the case. It needs further investigation to see why, I've entered this as alpheios-project/components#249

monzug commented 6 years ago

Bridget, there is also the deos issue that is slightly different (morphology from lookup is different from morphology with diagram)

On Mon, Oct 15, 2018 at 9:46 AM Bridget Almas notifications@github.com wrote:

ok. I figured out what's going on here. I do click on amens and then from the morphology pop-up, I click on the Games button and the scenario is the one from screenshot above with no declension in the game. if I click on Games from the lookup for amens (with no diagram involved) the scenario is the one that Irina has reported (with the declension in the game).

Ah ok, this is interesting. It means that something is wrong with the disambiguation. Declension is not provided in the treebank data, but the disamibugation is supposed to merge that data with the parser results without losing anything. But it would seem that is not the case. It needs further investigation to see why, I've entered this as alpheios-project/components#249 https://github.com/alpheios-project/components/issues/249

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/inflection-games/issues/3#issuecomment-429858575, or mute the thread https://github.com/notifications/unsubscribe-auth/AneqOaFOPHA8wm7cWZp23gLo2frE64fGks5ulJHLgaJpZM4XXrXT .

balmas commented 6 years ago

yep, will look at that in a minute.

balmas commented 6 years ago

I'm not sure if I am understanding everything about deos . I think it's related to alpheios-project/components#249 but a slightly different problem.

The disambiguation is failing to find the right entry from the morphological output for deos I think because of the capitalization. It should probably be doing a case-insensitive match, although I am not positive about this, because in fact capitalization can mean a different lemma, as in the case of a proper-name. (I.e God and god are quite legitimately different lemmas). (There is also an interesting parser behavior here with the variation of o vs u in the lemma, because deos gives you only the Deus, Dei lemma, whereas deus gives you both).

I think this in part confirms what I was expecting, that it will be difficult to have really solid games on text whose annotations haven't been fully curated and reviewed to make sure we have the full correct data for it.

The question of which declension is used - it does seem if it is pulling that from the matching cell in the table. I'm not sure that's actually wrong behavior?

monzug commented 6 years ago

no, it's not except that deus does not exist in Whitaker. it does create the entry ad hoc, that's my impression.

On Mon, Oct 15, 2018 at 10:34 AM Bridget Almas notifications@github.com wrote:

I'm not sure if I am understanding everything about deos . I think it's related to alpheios-project/components#249 https://github.com/alpheios-project/components/issues/249 but a slightly different problem.

The disambiguation is failing to find the right entry from the morphological output for deos I think because of the capitalization. It should probably be doing a case-insensitive match, although I am not positive about this, because in fact capitalization can mean a different lemma, as in the case of a proper-name. (I.e God and god are quite legitimately different lemmas). (There is also an interesting parser behavior here with the variation of o vs u in the lemma, because deos gives you only the Deus, Dei lemma, whereas deus gives you both).

I think this in part confirms what I was expecting, that it will be difficult to have really solid games on text whose annotations haven't been fully curated and reviewed to make sure we have the full correct data for it.

The question of which declension is used - it does seem if it is pulling that from the matching cell in the table. I'm not sure that's actually wrong behavior?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/inflection-games/issues/3#issuecomment-429877780, or mute the thread https://github.com/notifications/unsubscribe-auth/AneqORgWBeR5W1CJYU0MtyM0XMCnI6w4ks5ulJ0MgaJpZM4XXrXT .

balmas commented 6 years ago

yes that's correct. It's not really ad-hoc, it's creating the entry from the treebank data, which specifies the lemma as 'deus' rather than 'Deus'. In this case, I think actually the treebank data is wrong, the lemma should be Deus.

monzug commented 6 years ago

actually it should be 'deos'

On Mon, Oct 15, 2018 at 11:59 AM Bridget Almas notifications@github.com wrote:

yes that's correct. It's not really ad-hoc, it's creating the entry from the treebank data, which specifies the lemma as 'deus' rather than 'Deus'. In this case, I think actually the treebank data is wrong, the lemma should be Deus.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/inflection-games/issues/3#issuecomment-429912502, or mute the thread https://github.com/notifications/unsubscribe-auth/AneqOSVyKu5I6kv02Ga-duGW6_XxlZe6ks5ulLD1gaJpZM4XXrXT .

monzug commented 6 years ago

and 'me' is same scenario as deos.

irina060981 commented 6 years ago

As for amens - there is a problem with filtering inflections for disambiguated lexemes (it couldn't filter only masculine for example from masculine femine neuter

The whole description is published here https://github.com/alpheios-project/components/issues/249#issuecomment-430267328

monzug commented 6 years ago

an other one similar to deos is fugiendo. it does look for fugio not fugiendo. the matching in the inflection table is wrong.

On Tue, Oct 16, 2018 at 10:50 AM Sklyarova Irina notifications@github.com wrote:

As for amens - there is a problem with filtering inflections for disambiguated lexemes (it couldn't filter only masculine for example from masculine femine neuter

The whole description is published here alpheios-project/components#249 (comment) https://github.com/alpheios-project/components/issues/249#issuecomment-430267328

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/inflection-games/issues/3#issuecomment-430268253, or mute the thread https://github.com/notifications/unsubscribe-auth/AneqOXVFTnvg4NDXchqTEUJuC4qyb3wtks5ulfJOgaJpZM4XXrXT .

monzug commented 6 years ago

Most issues are fixed or have been moved to new issues. the only three that haven't been address are the following:

One more for @irina060981 - why there is (hard mode) in the Game header next to the word? Thanks

irina060981 commented 6 years ago

Hello, Monica :)

Hard mode - is the game mode without features list :) Click on it and the game would be able to be won only by clicking on the table .

So there is an answer for the second point and the last question at a time!

About yellow highlighting - it concerns the alignment ability (it is not inside the inflection games). But anyway I could answer your last questions about it: Yes it is by design - the idea of yellow highlighting is to show at the same time the word and its translation in the texts. As the translation and the text could be placed far from each other it was suggested to add some additional behaviour. So if you click on a word and it has aligned translated they both get highlighting and it sticks to them, because at the second step the screen could be scrolled to the translation or vice versa if one of them is out of the screen. This way we "mark" translations pairs. If you click the second time it will loose the highlighting.

monzug commented 6 years ago

Irina, Thanks you for prompt reply. as per hard mode, is it a temporary addition? if not, I do not think it is easy to understand what is suppose to do.

On Fri, Oct 19, 2018 at 10:09 AM Sklyarova Irina notifications@github.com wrote:

Hello, Monica :)

Hard mode - is the game mode without features list :) Click on it and the game would be able to be won only by clicking on the table .

So there is an answer for the second point and the last question at a time!

About yellow highlighting - it concerns the alignment ability (it is not inside the inflection games). But anyway I could answer your last questions about it: Yes it is by design - the idea of yellow highlighting is to show at the same time the word and its translation in the texts. As the translation and the text could be placed far from each other it was suggested to add some additional behaviour. So if you click on a word and it has aligned translated they both get highlighting and it sticks to them, because at the second step the screen could be scrolled to the translation or vice versa if one of them is out of the screen. This way we "mark" translations pairs. If you click the second time it will loose the highlighting.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/inflection-games/issues/3#issuecomment-431375903, or mute the thread https://github.com/notifications/unsubscribe-auth/AneqOeYEY5TdYjhCBjUoKXzIPJWfzCYqks5umd0OgaJpZM4XXrXT .

irina060981 commented 6 years ago

I don't think that it is the final design ofcourse, I think games will need some rearranging - but I had less time and wanted to add that ability for you to test, so I created the first variant that came to my mind :) So according to this , the hard mode link - is temporary, but hard mode ability - is a cool suggestion that is permanent !