search

alpheios-project / inflection-tables

Inflection Table Library
ISC License
3 stars 1 forks source link

Add paradigm cell match check #326

Closed irina060981 closed 4 years ago

irina060981 commented 4 years ago

The step for the issue - https://github.com/alpheios-project/inflection-tables/issues/289 For the issue https://github.com/alpheios-project/inflection-tables/issues/320

The check is the same as was used in components repo

Would be used with https://github.com/alpheios-project/components/pull/870

irina060981 commented 4 years ago

It looks okay. Would it be possible to add a test which validates the scenario described in alpheios-project/components#846? I am not sure where such a test belongs -- maybe as a functional test?

I believe that this is the test similiar to others I added to check paradigm tables in data folder. Added for the ἄγων (and also a fixture for it to fixtures repo)

irina060981 commented 4 years ago

Now I believe I could go ahead and merge the PR