alpheios-project / webextension

Alpheios Browser Extensions
ISC License
6 stars 2 forks source link

add button to open safari preferences to alpheios app #257

Closed balmas closed 4 years ago

balmas commented 4 years ago

per @kirlat the latest safari app extension api includes the ability to put a button on the app that opens the safari preferences button. We should do this.

balmas commented 4 years ago

3.0.1.81 (in Dropbox)

monzug commented 4 years ago

it's there. Not sure if it's clear enough that this is a button, can we add a click here or similar?

see screenshot Screen Shot 2019-10-15 at 3 27 01 PM

balmas commented 4 years ago

@kirlat let's change the button text to say Click to Open Safari Preferences and keep the 1 out of the button

kirlat commented 4 years ago

OK, will do that now

kirlat commented 4 years ago

@balmas: would something like below work? image

balmas commented 4 years ago

I think so. @monzug what do you think? Is it better?

monzug commented 4 years ago

absolutely

On Tue, Oct 15, 2019 at 3:54 PM Bridget Almas notifications@github.com wrote:

I think so. @monzug https://github.com/monzug what do you think? Is it better?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/webextension/issues/257?email_source=notifications&email_token=AJ32UOIMH4IO2FQIIAMIVUTQOXDRFA5CNFSM4JAQ3HWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBI24GA#issuecomment-542223896, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOM4YPO367UNT7YWOPTQOXDRFANCNFSM4JAQ3HWA .

balmas commented 4 years ago

@kirlat please go ahead with the PR. Thanks!

balmas commented 4 years ago

3.0.1.82

monzug commented 4 years ago

changes are in. see screenshot Screen Shot 2019-10-16 at 4 07 02 PM