In order to pass the Mozilla code review, we need to make sure the contents of the dist directory are fully produced by the build process and can be reproduced by running our build script. Per the reviewer:
"I see you already have the dist folder populated with minified files. We do not run build instructions on already minified files and need to delete the dist folder, that's why the instructions return error. ...We need to be able to reproduce the exact build, in order to finish the review. We can wait 14 days for you to provide us with a version that will fix this issue. Otherwise we will reject all affected versions."
So we need to update our code to move all of the files out of the dist directory and make sure it can be fully populated by the build process.
At the moment, the directory contains the following files which are not produced or updated by the build:
Manifest messages in _locales/en/messages.json
Package icons in icons
auth0chrome library in support/auth0
polyfill library in support/browser-polyfill
compatibility-fixes.js
manifest.json
env-webext.js
The build currently produces the following:
compiled css in style
compiled background.js
compiled content.js
I think we can do the following:
move the manifest.json, locales files, icons and compatibility-fixes.js to src and haven the build copy them there
add the auth0-code-update step to the normal build process so that it always gets copied from the node_modules to dist
add the polyfill library to our dependencies and copy it to the dist directory via the build process
I'm not sure of the best solution for the env-webext.js -- I have been wanting to change the way this works anyway because the dependency on the protected-config repo isn't usable for the switch to a full travis build. We could have a skeleton file that lives in the source directory and is populated by environment variables during the build. I'm open to other suggestions though.
@kirlat what do you think? Have I missed anything? We have to address this issue fairly urgently.
In order to pass the Mozilla code review, we need to make sure the contents of the dist directory are fully produced by the build process and can be reproduced by running our build script. Per the reviewer:
"I see you already have the dist folder populated with minified files. We do not run build instructions on already minified files and need to delete the dist folder, that's why the instructions return error. ...We need to be able to reproduce the exact build, in order to finish the review. We can wait 14 days for you to provide us with a version that will fix this issue. Otherwise we will reject all affected versions."
So we need to update our code to move all of the files out of the dist directory and make sure it can be fully populated by the build process.
At the moment, the directory contains the following files which are not produced or updated by the build:
_locales/en/messages.jsoniconssupport/auth0support/browser-polyfillThe build currently produces the following:
styleI think we can do the following:
I'm not sure of the best solution for the env-webext.js -- I have been wanting to change the way this works anyway because the dependency on the protected-config repo isn't usable for the switch to a full travis build. We could have a skeleton file that lives in the source directory and is populated by environment variables during the build. I'm open to other suggestions though.
@kirlat what do you think? Have I missed anything? We have to address this issue fairly urgently.