search

alpheios-project / webextension

Alpheios Browser Extensions
ISC License
6 stars 2 forks source link

Updated for the latest version of alpheios-core #305

Closed kirlat closed 4 years ago

kirlat commented 4 years ago

Refreshed to match alpheios-core

kirlat commented 4 years ago

I don't actually see any code changes here. Should I?

I think it does not require any changes but let me double check that.

balmas commented 4 years ago

when I built it the extension didn't load. I didn't debug further but it through an error in content.js somewhere.

kirlat commented 4 years ago

when I built it the extension didn't load. I didn't debug further but it through an error in content.js somewhere.

Let me run a series of tests to make sure it's fully working.

kirlat commented 4 years ago

@balmas: I still think webextension package is OK and does not require any changes. It work for me without a hitch. I've just updated the dependencies.

balmas commented 4 years ago

ok, you are probably right. I think I missed a step in the build earlier anyway. Feel free to merge this . I am going to try a new qa build shortly.

kirlat commented 4 years ago

Please let me know if you'll discover any problems with it.