search

alpheios-project / webextension

Alpheios Browser Extensions
ISC License
6 stars 2 forks source link

Use GitHub Actions for QA Build #307

Closed balmas closed 3 years ago

balmas commented 3 years ago

Fixes #306

This PR switches us from using Travis to GitHub Actions to create our QA build.

I think we will switch to this for production for the webextension too if all goes well, as it also addresses the following issues raised in alpheios-project/documentation#32

Note that with the env-webext.js in the dist.zip I don't think we really need an extra deploy step to S3 as we were thinking about. There is no perfect solution regarding that file, but I think it's probably okay to have it in the dist.zip as it does end up in the final package on the stores as well.

I'm not sure we want to migrate the others off of travis yet or not. Probably eventually.

kirlat commented 3 years ago

I'm also wondering if it makes sense to look into CI features that GitHub has to offer (but I do not know what can they do).

balmas commented 3 years ago

I'm also wondering if it makes sense to look into CI features that GitHub has to offer (but I do not know what can they do).

Yes, I think we probably could and should. I don't have a test step in this workflow because we don't actually have any webextension tests. But both test and deploy steps are definitely possible.