search

alpheios-project / webextension

Alpheios Browser Extensions
ISC License
6 stars 2 forks source link

Move options to data models #313

Closed irina060981 closed 3 years ago

irina060981 commented 3 years ago

It is update for this PR https://github.com/alpheios-project/alpheios-core/pull/551 It is really tiny - only changed references.

For now I couldn't build it properly because of https://github.com/alpheios-project/alpheios-core/issues/549 And check, but I checked my changes with embeded-lib. I talked to @kirlat about the issue and I think I could merge this really tiny change - while Kirill is working with his issue.

kirlat commented 3 years ago

I think Options should be exposed from components in the same way as Logger

Second that

irina060981 commented 3 years ago

I wrote my opinioin inside other PRs. But anyway let's do it as you suggest.

Then I would simply close the PR, it doesn't need any changes.