alpheios-project / webextension

Alpheios Browser Extensions
ISC License
6 stars 2 forks source link

Lexical data is loading from wordlist #330

Closed monzug closed 2 years ago

monzug commented 2 years ago

related to #328 ? in latest build Alpheios Reading Tools 3.4.1 build incr-3.4.x.20211118345 Alpheios Components 3.3.3-incr-3.4.x.20211116233 build i662-lexical-dicts.20211118457 in FF/PC. Have wordlist with latin words saved in both Greek and Latin language. When I double click on a latin word from wordlist (e.g. legatione), that it has been saved in the Greek list of words, it keeps loading the message: the lexical data is loading in the pop-up. I have to close the pop-up. No errors in the log.

legatione

page-language-greek

irina060981 commented 2 years ago

No, I don't think that it is related to that errors . But we have some problems with hanging lexical loading.

I saw it before simultaneously. Will check.

irina060981 commented 2 years ago

The problem is bigger. When you select a word from the page (in Firefox) it does two requests - with defined language and with page language. And adds two words with different language to the wordlist. You could see them as almost empty line in wordlist.

And when you try to click on them from wordlist - they could not be loaded, because - they don't have homonym. One copy with correct language has homonym and easily retrieved, the other with incorrect language - has no homonym and could not be retrieved.

And the most strange - it is reproduced only in Firefox (in my tests).

Need more time for investigation

monzug commented 2 years ago

uhm, not so happy to hear this. good luck digging into this issue...

On Fri, Nov 19, 2021 at 7:55 AM Sklyarova Irina @.***> wrote:

The problem is bigger. When you select a word from the page (in Firefox) it does two requests - with defined language and with page language. And adds two words with different language to the wordlist. You could see them as almost empty line in wordlist.

And when you try to click on them from wordlist - they could not be loaded, because - they don't have homonym. One copy with correct language has homonym and easily retrieved, the other with incorrect language - has no homonym and could not be retrieved.

And the most strange - it is reproduced only in Firefox (in my tests).

Need more time for investigation

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/webextension/issues/330#issuecomment-973801125, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOM4WOP7IFFB56EEIO3UMXYELANCNFSM5IJ3EXLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

irina060981 commented 2 years ago

I rechecked - it is reproduced in Chrome too. Easy steps:

irina060981 commented 2 years ago

Bug is fixed. New Release is published.

monzug commented 2 years ago

this is fixed in Alpheios Reading Tools 3.4.1 build incr-3.4.x.20211122338 Alpheios Components 3.3.3-incr-3.4.x.20211118338 build i330-loading-wordlist.20211122620 now I am getting the following: Screen Shot 2021-11-22 at 2 42 48 PM