alpheios-project / webextension

Alpheios Browser Extensions
ISC License
6 stars 2 forks source link

the wordlist pop-up is displayed behind morphology pop-up #335

Closed monzug closed 2 years ago

monzug commented 2 years ago

I do not know if this is new or if it has been around for a while, seen FF/Mac in Alpheios Reading Tools 3.4.1 build incr-3.4.x.20211123265 Alpheios Components 3.3.3-incr-3.4.x.20211123114 build i333-options-reset.20211123556

if I keep double clicking on greek words when page language is set to latin, the morphology pop-up will say that lexical query produced no results. then when I go to wordlist, the pop-up is open under the morphology pop-up. focus should be on the wordlist pop-up. see below Screen Shot 2021-11-23 at 4 41 53 PM

irina060981 commented 2 years ago

I was not able to reproduce it. (both on Windows and MacOS) It is manually in the code defined that panel should be upper (on layers) than popup. If you could reproduce it - could you screenshot the following:

image

image

Z-index is shown at the second part (Z-index defines layer order) - for panel it is 2010

image

For popup it is 2000

In your case Panel should have less than 2000. I need screenshots and exact values.

monzug commented 2 years ago

I have this screenshot. see if it can be helpful Screen Shot 2021-11-24 at 8 52 18 AM

monzug commented 2 years ago

z-index is 2011 Screen Shot 2021-11-24 at 8 56 45 AM

monzug commented 2 years ago

anyhow, I am not able to reproduce it right now. I took the screenshot this morning from yesterday scenario. After refreshing the page I could not repro it.

monzug commented 2 years ago

ok, I just got the wordlist behind the pop-up, what I did: start with greek language and go to wordlist and double click on any words in both latin and greek list, then change page language to latin, double click on few greek words and got the lexical query produced no results pop-up, then go to wordlist and click on any greek words saved under the latin list, wordlist pop-up goes under the last pop-up generated. Screen Shot 2021-11-24 at 9 04 47 AM Screen Shot 2021-11-24 at 9 06 02 AM Screen Shot 2021-11-24 at 9 06 16 AM

irina060981 commented 2 years ago

it is very strange - z-index property is correct

irina060981 commented 2 years ago

I was able to reproduce it on MAC/FF again - two copies of extension was attached It creates this mixed

May be there are some difference for the event that we now use for activation on MAC.

monzug commented 2 years ago

I noticed. can u reproduce doing the steps that I did in the last comment?

On Wed, Nov 24, 2021 at 9:13 AM Sklyarova Irina @.***> wrote:

it is very strange - z-index property is correct

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/webextension/issues/335#issuecomment-977631640, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOMIHPVYPLPXMS3APV3UNSNBLANCNFSM5IT2YZLA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

monzug commented 2 years ago

ah ok. is it only FF/MAC? we should check if it 's worth fixing it based on how many users are on FF/Mac.

On Wed, Nov 24, 2021 at 9:17 AM Sklyarova Irina @.***> wrote:

I was able to reproduce it on MAC/FF again - two copies of extension was attached It creates this mixed

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/webextension/issues/335#issuecomment-977634792, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOLF2XHBB3ODYJ2PC33UNSNQNANCNFSM5IT2YZLA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

irina060981 commented 2 years ago

it is strange - I will recheck.

irina060981 commented 2 years ago

I was able to reproduce it only on Mac/Firefox - it was not easy to reproduce - I clicked many times. But for now I completely does not understand how it could happen from code perspective. Will need more specific investigation.

irina060981 commented 2 years ago

I found the bug - it could be reproduced on any browser. We upload content (when reload) when the tab catches event that page loading process is complete. (it is our new workflow for removing permissions). But it turned out that a tab gets loading is complete two times - full complete and very full complete (I don't know what is the exact difference but it seems to me that the second emitts when all page resources are loaded).

Anyway I prevent from loading content on the lateter loaded event. So we should not have multiple popups now.

monzug commented 2 years ago

Brava!!!! so glad you found a fix. Thanks

On Thu, Nov 25, 2021 at 11:25 AM Sklyarova Irina @.***> wrote:

Assigned #335 https://github.com/alpheios-project/webextension/issues/335 to @monzug https://github.com/monzug.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/webextension/issues/335#event-5672005897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOJK3JBTXKFJXQIYBNLUNYFJTANCNFSM5IT2YZLA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

monzug commented 2 years ago

this is not longer reproducible in Alpheios Reading Tools 3.4.1 build incr-3.4.x.20211125333 Alpheios Components 3.3.3-incr-3.4.x.20211123271 build ext-i323-message.20211125609

monzug commented 2 years ago

to retest in chrome. looked good.

monzug commented 2 years ago

Chrome/PC and Mac on Alpheios Reading Tools 3.4.1 build incr-3.4.x.20211201209 Alpheios Components 3.3.3-incr-3.4.x.20211125318 build i331-la-lat-update-lang.20211201494