Regression on FF: right position and maximum pop-up width do not seem to work

[monzug]

regression on options in FF. I noticed that the maximum width of the pop-up does not seem to work as well as it did in the release. also Panel position sets to right does not work, it worked indeed in the release.

[irina060981]

Monica, I was not able to reproduce panel problem. For me on Firefox:

• panel position by clicking move panel to right/left icon

what do you mean saying -

the maximum width of the pop-up does not seem to work as well as it did in the release

Give me more details please

[monzug]

will reinstall the latest build again. the enlargement of the pop-up based on the setting maximum width of the pop-up did not enlarge the pop-up. will try again with new installation and get back to you. Thanks

On Tue, Nov 30, 2021 at 5:09 AM Sklyarova Irina @.***> wrote:

Assigned #337 https://github.com/alpheios-project/webextension/issues/337 to @monzug https://github.com/monzug.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/webextension/issues/337#event-5689193221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOMSSYAXP2G44JYIB4TUORE7NANCNFSM5I7U4I3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[monzug]

I clear cache and reinstall the latest build. I still see the problem with panel position set to right that does not do anything. the arrows to move left and right work perfectly. it's the setting that does not take action properly. see screenshots setting panel position set to right panel is on the left Not sure how it should work.

also if I set the width to unrestricted, the pop-up has same size as medium

[monzug]

I'll try on FF/PC again with latest build.

[irina060981]

About panel position - oh I see what do you mean. It does not change position on setting change (in Firefox and Chrome), only on icon clicking. I will check it

[irina060981]

Not sure how it should work.

Then how does it work in previous release if you are sure - it worked before?

[monzug]

same in FF/PC. it looks like it works only on first install, e.g. if panel position is set to right then panels will open on right. will check again against the latest release from January. I thought I could move the panel by changing the settings but that's what the arrows are for!!! how about the maximum width? it works as medium for me. will check against release

[monzug]

ok, it works as in the release so it's a non issue.

[monzug]

Not sure how it should work.

Then how does it work in previous release if you are sure - it worked before?

I searched github to see if there were any info about it but could not find. it has been a while and I really do not remember how it should work. anyhow it's same in latest release so good enough.

[irina060981]

I agree, when we have more time - I could investigate from code perspective. Our work is like archeology sometimes :)

[monzug]

Thanks irina , you are so right. I am almost done with regression and so far so good.

On Tue, Nov 30, 2021 at 4:07 AM Sklyarova Irina @.***> wrote:

I agree, when we have more time - I could investigate from code perspective. Our work is like archeology sometimes :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/webextension/issues/337#issuecomment-982427715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOKELCKCIPBHEAQEGBLUOSH4VANCNFSM5I7U4I3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.