search

alpheios-project / webextension

Alpheios Browser Extensions
ISC License
6 stars 2 forks source link

i-mus: it's not highlighted in the inflection table. why? #338

Closed monzug closed 2 years ago

monzug commented 2 years ago

this is in the release and also in latest build, so it's not relevant but I wondering why I do not get an exact match like for the adjective. go to https://www.tradurreantico.it/latino/grammatica-latina/morfologia/verbo/verbo-eo-latino/ and double click on i-mus. pop-up says that it's an adjective and a verb. go to inflection table, the adjective has a match that is highlighted in yellow. instead the verb does not have any match in the inflection table. why? the same in lookup. if I remove the dash, I have the exact match. imus

irina060981 commented 2 years ago

I believe that the main problem - that there is no match here. If we lookup the following - there would be exact much:

īmus

image

iimus

image

what exactly should be highlighted in the verb irregular table for i-mus?

monzug commented 2 years ago

should be the indicative active 1st person plural, same as imus - at least I was expecting a blue highlighted.

On Wed, Dec 1, 2021 at 11:44 AM Sklyarova Irina @.***> wrote:

Assigned #338 https://github.com/alpheios-project/webextension/issues/338 to @monzug https://github.com/monzug.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/webextension/issues/338#event-5698067374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOJOZQ2DUXFNRCFSSATUOX4CJANCNFSM5JBSMTZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

irina060981 commented 2 years ago

As I could see from the code

There is no support in the code for suffix match in irregular verbs, so you won't see any blue highlighting in irregular verbs table. So I could not improve anything here without some global changes for requirements. Do you have any questions here? Or we could close this issue?

monzug commented 2 years ago

please close. thanks

On Wed, Dec 1, 2021 at 12:12 PM Sklyarova Irina @.***> wrote:

As I could see from the code

  • blue highlignting is for suffix match
  • yellow highlighting is for full match

There is no support in the code for suffix match in irregular verbs, so you won't see any blue highlighting in irregular verbs table. So I could not improve anything here without some global changes for requirements. Do you have any questions here? Or we could close this issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alpheios-project/webextension/issues/338#issuecomment-983535614, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ32UOIZKW54KVSPR7W6TFDUOX7JRANCNFSM5JBSMTZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.