alpheios-project / webextension

Alpheios Browser Extensions
ISC License
6 stars 2 forks source link

Lexical query not found: different result in double-click vs wordlist #341

Open monzug opened 2 years ago

monzug commented 2 years ago

doing regression, so double clicking on several latin worlds. just realized that Accius and Varro from https://www.loebclassics.com/view/accius-by_works/1936/pb_LCL314.593.xml?rskey=p6oWMl&result=3 give a different result than same words from wordlist.

Accius from double click and lookup Screen Shot 2021-12-01 at 2 20 21 PM

Accius from wordlist Screen Shot 2021-12-01 at 2 20 10 PM

while Parergorum gives same result from double click and from wordlist: lexical query produced no results. an other inconsistency, @irina060981

irina060981 commented 2 years ago

I found the reason. If you click on Parergorum , then results would be the same from double click on page and double click . image

But as for Varro or Accius we see difference. The reason: Varro and Accius have full definitions that is ready after Lexical query produced no results is published. And we don't have a trigger that removes it.

But when you select such words from wordlist , than it has already full definitions and doesn't print this message.

I could suggest one of two solutions:

  1. add a trigger - remove message when full definitions are recieved
  2. remove condition about full definitions for the message -> then if a homonym has only full definitions, message would be printed anyway

@monzug , what do you think?

monzug commented 2 years ago

I noticed the full definition icon as the only difference between accius and words such as perergorum. I would not take any action at the moment but keep it alive for future releases. Thanks so much for digging into it!!!

irina060981 commented 2 years ago

ok