search

alpine-docker / git

A useful simple git container running in alpine linux, especially for tiny linux distro, such as RancherOS, which don't have package manager.
Apache License 2.0
155 stars 86 forks source link

Adding POWER(ppc64le) architecture support #26

Closed bahetiamit closed 4 years ago

bahetiamit commented 4 years ago

This change adds the support for POWER (ppc64le) architecture to the image. This was tested on master branch in travis. This is an extension to https://github.com/alpine-docker/git/pull/23

barthy1 commented 4 years ago

Hi @bahetiamit ! Thank you for this PR. Could you please share Travis build logs and link to the multi-arch image you got after the build?

bahetiamit commented 4 years ago

@barthy1

Please find the travis logs at - https://travis-ci.org/github/bahetiamit/git/builds/729545845 and travis built images at - https://hub.docker.com/repository/registry-1.docker.io/bahetiamit/git/tags?page=1

barthy1 commented 4 years ago

hey @ozbillwang I've verified that proposed code adds ppc64le arch to multi-arch apline/git images. I also verified that resulted ppc64le image is buildable and runnable for according arch. No changes are introduced for s390x or amd64 builds.

Are you ok to merge this code?

ozbillwang commented 4 years ago

Thanks, @barthy1

I am fine for the change. Let's merge it.

Please confirm if you can merge it directly.

snehlatamohite commented 4 years ago

@bahetiamit @barthy1 - Thanks for working on this.