search

alpine-docker / terragrunt

Auto-trigger docker build for terragrunt when new terraform version released
Apache License 2.0
35 stars 24 forks source link

Remove Dockerfile templating in main build #28

Closed JulianCBC closed 1 month ago

JulianCBC commented 8 months ago

Build args can be used to specify the version of containers in FROM lines, so skip a step in the build process by passing the Terraform version in as an argument instead of templating the Dockerfile.

I haven't done the same conversion to the EKS image as it doesn't build at present.

This conflicts with #27 so I'll sort that out once one of these is merged.

ozbillwang commented 8 months ago

Thanks for your PR. let's hold this change, until we plan to put OpenTofu (need be GA release) in it.

The existing tag could be terraform version, since no conflict.

JulianCBC commented 8 months ago

I don't understand, this isn't changing the tags, this is just some cleanup.

ozbillwang commented 1 month ago

@JulianCBC

Looks fine to me now.

But there are some new PRs merged recently, could you resolve the conflicts?

ozbillwang commented 1 month ago

TODO list:

New tags for discussion

JulianCBC commented 1 month ago
  • alpine/terragrunt:otf1.7.1 or alpine/terragrunt:ot1.7.1

"tf" is TerraForm, i.e. letter per syllable, so "otf" being OpenToFu also makes sense.

JulianCBC commented 1 month ago

I've rebased this over the latest changes in master. Let's handle that TODO list in separate pull requests.

ozbillwang commented 1 month ago

TODO list:

  • add opentofu binary in this image
  • define new tags
  • No latest tag any more.
  • rollback the new tags we merged last time (1, 1.8)

New tags for discussion

  • alpine/terragrunt:tf1.8.3
  • alpine/terragrunt:otf1.7.1 or alpine/terragrunt:ot1.7.1

opentofu has been installed in the latest image now.

docker run -ti --rm alpine/terragrunt tofu --version
OpenTofu v1.7.1
on linux_amd64

For examples, below tags are supported now: