alpinelinux / alpine-docker-gitlab

[MIRROR] Gitlab docker image based on Alpine Linux
https://gitlab.alpinelinux.org/alpine/infra/docker/gitlab
MIT License
14 stars 16 forks source link

15.11-stable, missing rack_attack.rb.example #14

Closed supar closed 1 year ago

supar commented 1 year ago
docker compose up

....
gitlab-gitlab-1        | Installing missing config: gitlab/initializers/rack_attack.rb
gitlab-gitlab-1        | install: can't stat '/home/git/gitlab/config/initializers/rack_attack.rb.example': No such file or directory
...

There is no such file in the image

docker run -it --rm --entrypoint=/bin/sh alpinelinux/gitlab:15.11.6
/ # cd /home/git/gitlab/config/initializers
/home/git/gitlab/config/initializers # ls -l
...
-rw-r--r--    1 git      git           1090 Jun  3 09:37 rack_VULNDB-255039_patch.rb
-rw-r--r--    1 git      git             76 Jun  3 09:37 rack_attack.rb
-rw-r--r--    1 git      git           1000 Jun  3 09:37 rack_lineprof.rb
-rw-r--r--    1 git      git           1076 Jun  3 09:37 rack_multipart_patch.rb
-rw-r--r--    1 git      git           1222 Jun  3 09:37 rack_timeout.rb
...
Ikke commented 1 year ago

Apparently this was removed in gitlab 12.4 and is now managed through the admin panel. I'll remove the code from the entrypoint.

Ikke commented 1 year ago

Just FYI, I still notice issues with 15.12 related to upgrading the image to ruby 3.1 and I'm still debugging it.

supar commented 1 year ago

Just FYI, I still notice issues with 15.12 related to upgrading the image to ruby 3.1 and I'm still debugging it.

I removed that line to move forward but failed on:

gitlab-gitlab-1        | Setting up gitlab...
gitlab-gitlab-1        | bundler: failed to load command: rake (/usr/local/bin/rake)
gitlab-gitlab-1        | /usr/local/bundle/gems/bundler-2.4.12/lib/bundler/definition.rb:524:in `materialize': Could not find gssapi-1.3.1, timfel-krb5-auth-0.8.3, grape-swagger-1.5.0, grape-swagger-entity-0.5.1, graphql-docs-2.1.0, lefthook-1.3.10, rubocop-1.43.0, solargraph-0.47.2, letter_opener_web-2.0.0, lookbook-1.5.3, better_errors-2.9.1, sprite-factory-1.7.1, listen-3.7.1, deprecation_toolkit-1.5.1, bullet-7.0.2, pry-byebug-3.10.1, pry-rails-0.3.9, pry-shell-0.6.1, awesome_print-1.9.2, database_cleaner-1.7.0, factory_bot_rails-6.2.0, rspec-rails-6.0.1, ffaker-2.10.0, spring-4.1.0, spring-commands-rspec-1.0.4, gitlab-styles-10.0.0, haml_lint-0.40.1, bundler-audit-0.7.0.1, benchmark-ips-2.11.0, benchmark-memory-0.2.0, knapsack-1.21.1, crystalball-0.7.0, simple_po_parser-1.1.6, png_quantizator-0.2.1, parallel-1.22.1, test_file_finder-0.1.4, sigdump-0.2.4, pact-1.63.0, fuubar-2.2.0, rspec-retry-0.6.2, rspec_profiling-0.0.6, rspec-benchmark-0.6.0, rspec-parameterized-1.0.0, capybara-3.39.0, capybara-screenshot-1.0.26, selenium-webdriver-3.142.7, graphlyte-1.0.0, shoulda-matchers-5.1.0, email_spec-2.2.0, webmock-3.18.1, rails-controller-testing-1.0.5, test-prof-1.2.1, rspec_junit_formatter-0.6.0, guard-rspec-4.7.3, axe-core-rspec-4.6.0, derailed_benchmarks-2.1.2, escape_utils-1.2.1, extended-markdown-filter-0.6.0, gemoji-3.0.1, sass-3.5.5, rubocop-ast-1.24.1, backport-1.2.0, diff-lcs-1.5.0, e2mmap-0.1.0, jaro_winkler-1.5.4, yard-0.9.26, letter_opener-1.7.0, htmlbeautifier-1.4.2, redcarpet-3.6.0, coderay-1.1.3, rb-fsevent-0.11.2, rb-inotify-0.10.1, uniform_notifier-1.16.0, byebug-11.1.3, pry-0.14.2, tty-markdown-0.7.2, tty-prompt-0.23.1, factory_bot-6.2.0, rspec-core-3.12.0, rspec-expectations-3.12.2, rspec-mocks-3.12.3, rspec-support-3.12.0, rubocop-graphql-0.19.0, rubocop-performance-1.16.0, rubocop-rails-2.17.4, rubocop-rspec-2.18.1, haml-5.2.2, sysexits-1.2.0, pact-mock_service-3.10.0, pact-support-1.18.1, rspec-3.12.0, term-ansicolor-1.7.1, sqlite3-1.6.0, benchmark-malloc-0.2.0, benchmark-perf-0.6.0, benchmark-trend-0.4.0, rspec-parameterized-core-1.0.0, rspec-parameterized-table_syntax-1.0.0, xpath-3.2.0, launchy-2.5.0, childprocess-3.0.0, hashdiff-1.0.1, guard-2.16.2, guard-compat-1.2.1, axe-core-api-4.6.0, dumb_delegator-1.0.0, virtus-2.0.0, dead_end-3.1.1, heapy-0.2.0, mini_histogram-0.3.1, ruby-statistics-3.0.0, sass-listen-4.0.0, strings-0.2.1, tty-screen-0.8.1, tty-reader-0.9.0, rubocop-capybara-2.17.0, filelock-1.1.1, find_a_port-1.0.1, expgen-0.1.1, tins-1.31.1, proc_to_ast-0.1.0, unparser-0.6.7, binding_of_caller-1.0.0, lumberjack-1.2.7, nenv-0.3.0, notiffany-0.1.3, shellany-0.0.1, axiom-types-0.1.1, coercible-1.0.0, descendants_tracker-0.0.4, strings-ansi-0.2.0, unicode_utils-1.4.0, tty-cursor-0.7.1, wisper-2.0.1, sync-0.5.0, debug_inspector-1.1.0, ice_nine-0.11.2, thread_safe-0.3.6 in locally installed gems (Bundler::GemNotFound)

Suppose this case belongs to ruby upgrade to 3.1, because previous version of alpine and ruby didn't fails

Ikke commented 1 year ago

Yes, that's the issue I'm troubleshooting.

Ikke commented 1 year ago

I found the issue and pushed it (together with removing rack_attack.rb.example).