alpinelinux / alpine-make-vm-image

Make customized Alpine Linux disk image for virtual machines
MIT License
300 stars 101 forks source link

If target image is a block device, access it directly #22

Closed omnivagant closed 1 year ago

omnivagant commented 3 years ago

This will allow a user to specify a block device, like an LVM volume or ZFS zvol, as target.

jirutka commented 2 years ago

This is a nice idea, but it’s incomplete – cleanup function (alpine-make-vm-image:143-146) must be modified.

omnivagant commented 2 years ago

Like so?

In some sense I feel like I'm a bit lazy here in keeping the $nbd_dev name even if it isn't.

jirutka commented 2 years ago

Yes, there are more things that should be renamed and documented to make sense after this change.

omnivagant commented 1 year ago

What if we just call it $disk_dev instead, would that be enough?

jirutka commented 1 year ago

Yes, that’s fine, but the help message needs to be updated as well.

omnivagant commented 1 year ago

Of course, like so?

jirutka commented 1 year ago

Yes, thanks!