Fix for temporary storage overflow warning - Githubissues

alpinestudios / oogabooga

ooga booga

Other

221 stars 245 forks source link

Fix for temporary storage overflow warning #17

Closed kacpercwiklinski closed 2 months ago

kacpercwiklinski commented 2 months ago

Why do we need this?

Now the user is not warned about temp memory overflow which may introduce hard to debug bugs with memory management.

Describe at least one specific and practical problem this solves for people developing a game

The buffer overflown and the pointers have been overwritten - undefined behavior, the pc fly into space. This fix fixes what the warning is meant to be. Warn in overflow situation to avoid potential bugs.

Does this add complexity/friction for people making games? If so, how do you justify that?

There's no complexity in this PR.

asbott commented 2 months ago

Thank you. When it's little bug fixes like this, you don't need to go through the whole questionnaire if you don't want to and can just explain the problem you fixed.

Have a great day!