Open alpmestan opened 6 years ago
For process001 and process002, the workaround I use is to copy the ls
binary to /bin
.
Would it be that bad for other systems if the test was changed to just invoke ls
assuming it's in the PATH? I'd expect this to work on most systems I've laid my hands on, but that's not a whole lot :-)
Would it be that bad for other systems if the test was changed to just invoke ls assuming it's in the PATH?
I guess an easy way to check whether it breaks on supported systems is to make a Diff and see whether CI passes. And for systems that are not checked by CI, there are probably far more failures we're not aware of anyway.
Yes, I think that just running ls
would be much preferred. Afterall, POSIX doesn't guarantee that ls
will be in /bin
AFAIK. It would be great to have this fixed; I've been ignoring this issue ever since I switched to NixOS.
Put together a PR for those process
tests at https://github.com/haskell/process/pull/133
When running make
, building stage2
produces a lot of warnings like this one:
"inplace/bin/ghc-stage1" -optc-fno-stack-protector -optc-Wall -optc-Wall -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes -optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return -optc-Wpointer-arith -optc-Wmissing-noreturn -optc-Wnested-externs -optc-Wredundant-decls -optc-Wundef -optc-Iincludes -optc-Iincludes/dist -optc-Iincludes/dist-derivedconstants/header -optc-Iincludes/dist-ghcconstants/header -optc-Irts -optc-Irts/dist/build -optc-DCOMPILING_RTS -optc-DFS_NAMESPACE=rts -optc-fno-strict-aliasing -optc-fno-common -optc-Irts/dist/build/./autogen -optc-Werror=unused-but-set-variable -optc-Wno-error=inline -optc-O2 -optc-fomit-frame-pointer -optc-g -optc-fno-omit-frame-pointer -optc-g -optc-O0 -optc-DRtsWay=\"rts_thr_debug\" -static -optc-DTHREADED_RTS -optc-DDEBUG -eventlog -O0 -H64m -Wall -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header -Irts -Irts/dist/build -DCOMPILING_RTS -DFS_NAMESPACE=rts -this-unit-id rts -dcmm-lint -i -irts -irts/dist/build -Irts/dist/build -irts/dist/build/./autogen -Irts/dist/build/./autogen -O2 -Wcpp-undef -O0 -Wnoncanonical-monad-instances -c rts/fs.c -o rts/dist/build/fs.thr_debug_o
In file included from /nix/store/xz3pnhwaanqq18nk47zmr8fr6yc7qpjf-glibc-2.27-dev/include/bits/libc-header-start.h:33:0: error:
0,
from /nix/store/xz3pnhwaanqq18nk47zmr8fr6yc7qpjf-glibc-2.27-dev/include/stdio.h:27,
from rts/fs.h:14,
from rts/fs.c:11:
/nix/store/xz3pnhwaanqq18nk47zmr8fr6yc7qpjf-glibc-2.27-dev/include/features.h:381:4: error:
warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
# warning _FORTIFY_SOURCE requires compiling with optimization (-O)
^~~~~~~
|
381 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
| ^
When running ./validate
, these warnings become errors.
a8c71037e04
926954196f
Using ghc commit 93220d46fc,
./validate --fast
gives me:./validate --slow
had many more last time I tried (several weeks ago).