Misc cleanup after complete read through - Githubissues

alps-io / spec

ALPS Specification documents.

59 stars 13 forks source link

Misc cleanup after complete read through #51

Closed fosrias closed 10 years ago

fosrias commented 10 years ago

@mamund Please review and merge. I have regenerated all the files with the included script. There are a few sections with leftover [TK] etc that you would be best to address.

The following PR:

Fixes misc typos, adds spaces, punctuation, etc.
Makes some phrases into sentences for better readability and fixes grammar.
Makes samples more readable (per input from @steveklabnik).
Highlights as suggested change to a few sections (I add comments in the PR to point them out).

fosrias commented 10 years ago

@mamund Does not show up in the PR, but there are some TBD like items still in Section 3 and in Section 5.

mamund commented 10 years ago

@fosrias do you want to change your company reference (medidata) in the doc?

fosrias commented 10 years ago

@mamund I will change the company reference. If you let me know when you are done reviewing this, I will address any comments/update PR accordingly for your final review.

On Tue, Aug 5, 2014 at 6:36 AM, Mike Amundsen notifications@github.com wrote:

@fosrias https://github.com/fosrias do you want to change your company reference (medidata) in the doc?

— Reply to this email directly or view it on GitHub https://github.com/alps-io/spec/pull/51#issuecomment-51197632.

mamund commented 10 years ago

cool, i am walking through the doc now and will ping you when i have it ready for your review again.

mamund commented 10 years ago

@fosrias: i added my commits to yours. check it out and let me know.

looks like we'll have some fun on the merge! ;)

fosdev commented 10 years ago

@mamund Final minor fixes done and merge conflict resolved. However, when you reformatted code examples indentation to 2 spaces, you only did it on the examples in section 2, but not section 1. Was that on purpose? Past that ready to merge.

mamund commented 10 years ago

@fosrias

!derp! code in section #1 now updated, too.

fosdev commented 10 years ago

@mamund Looks good. Merge away (since I did most of the edits in this PR).

mamund commented 10 years ago

Out on errands. Will b do the merge and Web site update later this afternoon.

Great stuff. On Aug 10, 2014 2:13 PM, "Mark W. Foster" notifications@github.com wrote:

@mamund https://github.com/mamund Looks good. Merge away (since I did most of the edits in this PR).

— Reply to this email directly or view it on GitHub https://github.com/alps-io/spec/pull/51#issuecomment-51722375.

mamund commented 10 years ago

ok, merged, deleted, closed issue #51.

looks pretty clean to me!

i'll be posting this to the public website and let it stew for a day or so. then i'll work up the first IETF commit (remove the ".J") and start the submit process.

once that's done we can look over the remaining issues, prioritize, and set a new milestone

thanks again.

mamund +1.859.757.1449 skype: mca.amundsen http://amundsen.com/blog/ http://twitter.com/mamund https://github.com/mamund http://linkedin.com/in/mamund

On Sun, Aug 10, 2014 at 3:12 PM, mike amundsen mamund@yahoo.com wrote:

Out on errands. Will b do the merge and Web site update later this afternoon.

Great stuff. On Aug 10, 2014 2:13 PM, "Mark W. Foster" notifications@github.com wrote:

@mamund https://github.com/mamund Looks good. Merge away (since I did most of the edits in this PR).

— Reply to this email directly or view it on GitHub https://github.com/alps-io/spec/pull/51#issuecomment-51722375.