Closed prestonvasquez closed 1 year ago
hey, could I take a stab at this? Would like to work if open.
@krishnaindani You're assigned!
Thanks
The way I was thinking is to use a map[string]bool while we loop to make newTX here https://github.com/alpine-hodler/gidari/blob/main/internal/transport/transport.go#L269 and maintaining a dns entry in map that had we have already looped over. And if duplicated just log it. How does this sounds or would you be able to recommend any better idea here?
@krishnaindani That sounds reasonable to me! In order to maintain the complexity requirements for Hacktoberfest, do you think you could take a look at Issue #180 and combine the two into one PR?
Sure will take a look
Could you assign me that issue?
@krishnaindani Thank you! Since you have not made your first contribution can you comment on that issue so that you are in the scope of assignable engineers?
@krishnaindani Are you still interested in pursuing this issue?
Closed by #360
A user could create a configuration file with duplicate connection strings like this:
If this happens, we need to log a warning in
transport.Config#repos
that the user did this, and only create a repo for one of the connection strings.