alptium / branko.spalovic

MIT License
0 stars 0 forks source link

Advanced Gradebook - Handling different class sizes #7

Open lespabrandzulic82 opened 6 years ago

lespabrandzulic82 commented 6 years ago

hi, could you take a look my code for advansed gradebook @valentinacupac

valentinajemuovic commented 6 years ago

@lespabrandzulic82, good work, however, please do the following corrections:

  1. Please review formatting rules as per here and previous comments https://github.com/alptium/valentina.cupac/wiki/03.-Hello-World
  2. Write "numStudents" instead of "numbStudents" because the word "numb" has a different meaning.
  3. Don't have separate String [][] students = null; and then students = new String[numbStudents][2]; ... but instead String [][] students = new String[numbStudents][2]; because in general, whenever possible, we combine these together, instead of making something null and then assigning.
  4. Apply rule 3 to other instances.
  5. In case of int t = 0 please use i generally within loops (convention).
  6. The construction String [][] students is correct but not really a typical solution, instead, use String [] names and then String[] surnames, which is the more typical solution, reason is because it reflects what is actually stored within the variable... (if not clear, let me know)
lespabrandzulic82 commented 6 years ago

I have made corrections like you said in your comments. @valentinacupac

valentinajemuovic commented 6 years ago

@lespabrandzulic82:

  1. Read my comment above. I wrote 1-dimensional arrays String [] names and then String[] surnames, but yet in code there are 2-dimensional arrays String [][] names and String [][] surnames.
  2. See https://github.com/alptium/valentina.cupac/wiki/03.-Hello-World comment 15, 29, 32
lespabrandzulic82 commented 6 years ago

I corrected the errors, check again, and sorry. Tell me if you think that I can continue my tasks with grade book @valentinacupac

lespabrandzulic82 commented 6 years ago

Can I go on another advanced gradebook task? @valentinacupac

valentinajemuovic commented 6 years ago

@lespabrandzulic82, yes,.

lespabrandzulic82 commented 6 years ago

ok, thanks @valentinacupac