search

alptium / branko.spalovic

MIT License
0 stars 0 forks source link

Elite Sports Team Selector (OOP) #8

Open lespabrandzulic82 opened 6 years ago

lespabrandzulic82 commented 6 years ago

Could you take a look at my elite sport selector OOP task and whether it's ok, and do you have any suggestions for repair or improvement? @valentinacupac

valentinajemuovic commented 6 years ago

@lespabrandzulic82, looks good.

  1. Remove the comments // Attributes for class Player, Constructor, etc... pwerhaos I had those comments in my code for educational purposes to explain Java classes, but don't include it here, since the read (Java developer) should know this.
  2. Rename "playerDemo" to something else, imagine this is a real application...
  3. Line 18 indentation is not correct.
  4. Use ArrayList to support multiple players, see #5.
  5. Please delete your duplicate project Elite Sports Team Selector (OOP) since all this currently is about refactoring the existing elite-sport-team-selector project.
lespabrandzulic82 commented 6 years ago

I have deleted this project and added to the elite-sport-team-selector project. Also, I have made corrections from above. @valentinacupac

valentinajemuovic commented 6 years ago

@lespabrandzulic82, as can be seen here https://github.com/alptium/branko.spalovic there are now 3 projects for Elite Sports Selector, please re-check your merge.