search

alptium / vasilija.joksimovic

MIT License
0 stars 0 forks source link

Hello world #2

Closed vasilijajoksimovic closed 6 years ago

vasilijajoksimovic commented 6 years ago

@valentinacupac I've done the task, you can review it now.

valentinajemuovic commented 6 years ago

@vasilijajoksimovic, I cannot see hello-world project

Instructions: https://github.com/alptium/valentina.cupac/wiki/03.-Hello-World See my repository where there is hello-world https://github.com/alptium/valentina.cupac

vasilijajoksimovic commented 6 years ago

@valentinacupac Can you see it now? I've made a new one...

valentinajemuovic commented 6 years ago

@vasilijajoksimovic, but please from your repository delete the files: .classpath .project

Delete these ONLY from vasilija.joksimovic.

valentinajemuovic commented 6 years ago

P.S. Because those were the files that were incorrectly created from the first time when you were making hello world...

vasilijajoksimovic commented 6 years ago

@valentinacupac OK, done.

valentinajemuovic commented 6 years ago

@vasilijajoksimovic, when fixes are done, please move back to "In review" so that it appears in my list. So whenever you finish fixes, move to "In review" again. Please do that now.

valentinajemuovic commented 6 years ago

@vasilijajoksimovic:

  1. Please put Main.java into a package, beause all classes should be placed into a package. See https://github.com/alptium/valentina.cupac/wiki/03.-Hello-World step 17.
  2. Please delete "// TODO Auto-generated method stub" because you've added code.
vasilijajoksimovic commented 6 years ago

@valentinacupac Redone.

valentinajemuovic commented 6 years ago

@vasilijajoksimovic, correct.