alrevuelta / cONNXr

Pure C ONNX runtime with zero dependancies for embedded devices
MIT License
193 stars 31 forks source link

Implemented the Sigmoid function for floats #72

Closed bjornite closed 4 years ago

nopeslide commented 4 years ago

Thanks for contributing! Could you also uncomment the corresponding operator tests in /src/test/tests.c?

alrevuelta commented 4 years ago

Thanks for your contribution! Couple of comments:

Since you have contributed with an operator, you might have some specific feedback about how the process was, do you? We are trying to make contributing as easy as possible, having a modular and solid architecture where a new operator can be easily implemented without knowing much about what is under the hood, so any feedback is appreciated.

@nopeslide Any comments?

Thanks!

bjornite commented 4 years ago

Made the changes to enable the tests now. Thanks for the pointers.

@alrevuelta I found it straight forward to implement the operator. You've done a great job making it easy to contribute in my opinion :)

alrevuelta commented 4 years ago

@bjornite Thanks for the contribution!