Closed Coderitter-GmbH closed 3 years ago
Thanks for the PR! I noticed a few things and commented accordingly.
I still have to:
To use default_dilations, default_pads and default_strides I have to allocate memory. Doesn't that cause memory leak, because later I don't know if op_ctx->pads contains the pointer from a_pads->ints or my self allocated memory (ARRAYDUP)
To use default_dilations, default_pads and default_strides I have to allocate memory. Doesn't that cause memory leak, because later I don't know if op_ctx->pads contains the pointer from a_pads->ints or my self allocated memory (ARRAYDUP)
you have multiple options to solve this:
I think I would some day prefer the comparison, since it's simple and moves the annoying stuff into the free function but atm I would simply dup everything. we can always start from there for optimizations, especially since the free function is not utilized at this point
I think I would some day prefer the comparison, since it's simple and moves the annoying stuff into the free function but atm I would simply dup everything. we can always start from there for optimizations, especially since the free function is not utilized at this point
Okay dup everything it is for now
Can you look over it again?
That should be it
Nice. thanks again for this PR
First Implementation of the ConvTranspose2d Operator. Its not support every combination of parameters but it passes the most tests.
fixes #79