zqqw
commented
3 years ago Building at this recent commit: https://github.com/alsa-project/alsa-lib/commit/81e7923fbfad45b2f353a4d6e3053af51f5f7d0b reverting this commit: https://github.com/alsa-project/alsa-lib/commit/5275d170e05639473e68e5feb349aec65bf26428 and partially reverting this commit (the last bit, the first part of it makes no difference): https://github.com/alsa-project/alsa-lib/commit/28cc099d9ea3962b033cb1cb9c3e07db828d9ff7 fixes espeak and it worked again. I don't know the details of why this happens, but hopefully isolating the exact cause will help to find a good solution. Although it initially worked with espeak like this, later when I tried to listen to audio in the browser having left an espeak process running in the terminal, there was no sound, and then espeak stopped working again after that, so this is not a fully working patch.
$ git diff
diff --git a/src/conf.c b/src/conf.c
index d863dec6..a936c28c 100644
--- a/src/conf.c
+++ b/src/conf.c
@@ -1994,9 +1994,7 @@ int _snd_config_load_with_include(snd_config_t *config, snd_input_t *in,
SNDERR("%s:%d:%d:%s", fd->name ? fd->name : "_toplevel_", fd->line, fd->column, str);
goto _end;
}
- err = get_char(&input);
- fd = input.current;
- if (err != LOCAL_UNEXPECTED_EOF) {
+ if (get_char(&input) != LOCAL_UNEXPECTED_EOF) {
SNDERR("%s:%d:%d:Unexpected }", fd->name ? fd->name : "", fd->line, fd->column);
err = -EINVAL;
goto _end;
diff --git a/src/pcm/pcm_plugin.c b/src/pcm/pcm_plugin.c
index 24c9941d..407af156 100644
--- a/src/pcm/pcm_plugin.c
+++ b/src/pcm/pcm_plugin.c
@@ -552,7 +552,8 @@ static int snd_pcm_plugin_status(snd_pcm_t *pcm, snd_pcm_status_t * status)
err = snd_pcm_status(plugin->gen.slave, status);
if (err < 0)
return err;
- snd_pcm_plugin_sync_hw_ptr(pcm, status->hw_ptr, status->avail);
+ status->appl_ptr = *pcm->appl.ptr;
+ status->hw_ptr = *pcm->hw.ptr;
/*
* For capture stream, the situation is more complicated, because
* snd_pcm_plugin_avail_update() commits the data to the slave pcm.
perexg
In archlinux amd64 upgrading alsa-lib from 1.2.4 - 1.2.5 breaks the espeak application https://sourceforge.net/projects/espeak/.
I see extra errors in espeak output eg