Adjust appl_ptr for multi plugin on rewind/forward operations

alsa-project / alsa-lib

The Advanced Linux Sound Architecture (ALSA) - library

GNU Lesser General Public License v2.1

366 stars 177 forks source link

Adjust appl_ptr for multi plugin on rewind/forward operations #161

Closed sava-j closed 3 years ago

sava-j commented 3 years ago

When doing rewind or forward operations, application pointer needs to be properly adjusted, in the same way when doing commit/write operations.
Introduce helper functions for manipulating the application pointer.

perexg commented 3 years ago

Looks good, but could you use snd_pcm_mmap_appl_forward and snd_pcm_mmap_appl_backward ?

sava-j commented 3 years ago

Hi,

Sure - I thought it was a bit nicer to introduce separate functions, but giving that we use mmap's functions extensively in multi, it is a better way. I'll amend the commit. Thank you!

sava-j commented 3 years ago

Hello @perexg,

I removed the added helper functions and replaced them with snd_pcm_mmap_appl_forward and snd_pcm_mmap_appl_backward.

Thanks, Sava

perexg commented 3 years ago

Applied in https://github.com/alsa-project/alsa-lib/commit/1aeea94ce81d2ccead17399a99bd0ecfe53025f0 . Thank you for your contribution.