search

alsa-project / alsa-lib

The Advanced Linux Sound Architecture (ALSA) - library
GNU Lesser General Public License v2.1
345 stars 176 forks source link

params argument to `SNDRV_PCM_IOCTL_SW_PARAMS` should be pointer #329

Closed dancrossnyc closed 1 year ago

dancrossnyc commented 1 year ago

Commit 2115cdb4d added a call to the SNDRV_PCM_IOCTL_SW_PARAMS ioctl on line 675 of src/pcm/pcm_hw.c, but passes the sw_params argument by value; this should be passed by pointer.

I ran across this in the context of the direwolf software modem for amateur radio; debugging details are in https://groups.io/g/direwolf/message/8286.

The patch is trivial; I will send a PR.

Thanks!

perexg commented 1 year ago

Thank you for this report.

dancrossnyc commented 1 year ago

Happy to do it; thank you for the quick turnaround!