configure: Add large file support via CFLAGS

alsa-project / alsa-lib

The Advanced Linux Sound Architecture (ALSA) - library

GNU Lesser General Public License v2.1

364 stars 177 forks source link

configure: Add large file support via CFLAGS #333

Closed kendase3 closed 1 year ago

kendase3 commented 1 year ago

Currently scanelf (pax-utils) detects missing LFS support in the following files/calls: fopen,__open_2,mmap,lseek,open /usr/lib/libasound.so.2.0.0 fopen,open /usr/lib/libatopology.so.2.0.0

Note that this may cause problems on systems with a 32-bit kernel, but I've tested playing audio on a more recent 32-bit system with a 64-bit kernel.

Notably AC_SYS_LARGEFILE (currently used in alsa-utils for example) did not solve the issue for my case, whereas FILE_OFFSET_BITS did.

Let me know if you'd prefer an alternative approach!

perexg commented 1 year ago

AC_SYS_LARGEFILE should work. But the output is written to include/config.h file so we need to include this file as first in our source files. I've tried to do this in ad3a8b8b314e0bcd254e149d7a20c1455ecaf480 . If you hit a problem with a specific symbol, please, note it here or create a new issue.

heitbaum commented 1 year ago

Hi @perexg - believe the first issue of largefile on a 32bit compile of Kodi.

https://github.com/LibreELEC/LibreELEC.tv/pull/8126
https://forum.libreelec.tv/thread/27500-libreelec-nightly-rpi2-latest-builds-fail-to-boot/ I’ll raise an issue against this. Workaround (revert) using configure option done, but not sure on the implications (if any on the 64bit compiles) or if the configure option needs to be wrapped in 32bit.

perexg commented 1 year ago

@heitbaum : Fixed in 0e3dfb9f705ca78be34cd70fd59d67c431e29cc7 and 81a7a93636d9472fcb0c2ff32d9bfdf6ed10763d .