alsa-project / alsa-lib

The Advanced Linux Sound Architecture (ALSA) - library
GNU Lesser General Public License v2.1
364 stars 177 forks source link

snd_seq_ev_set_ump_data() stack smashing #346

Closed symdeb closed 1 year ago

symdeb commented 1 year ago

snd_seq_ev_set_ump_data(&umpev, buffer, len);

When called with len > 4 causes stack smashing. A ump messages is maximum four 32bit values. Proposal solution, return error when len > 4 ?

tiwai commented 1 year ago

Yes, a range check makes sense.