search

alsa-project / alsa-plugins

The Advanced Linux Sound Architecture (ALSA) - plugins
GNU Lesser General Public License v2.1
41 stars 28 forks source link

Question about upmix plugin #25

Closed krumpfwylg closed 3 years ago

krumpfwylg commented 3 years ago

Hi, I've noticed the latest commits done to the upmix plugin, but there's something I don't understand. Line 24 of pcmupmix.c is #define UPMIX_PCM_FORMAT SND_PCM_FORMATS16 Does that mean the upmix plugin is still only capable of using S16_LE format ? Or does the UPMIX_PCM_FORMAT value can get changed to S32_LE by tweaking it in asoundrc file ?

perexg commented 3 years ago

Hi, I've noticed the latest commits done to the upmix plugin, but there's something I don't understand. Line 24 of pcmupmix.c is #define UPMIX_PCM_FORMAT SND_PCM_FORMATS16 Does that mean the upmix plugin is still only capable of using S16_LE format ?

Yes. But you can change source.

Or does the UPMIX_PCM_FORMAT value can get changed to S32_LE by tweaking it in asoundrc file ?

No.

krumpfwylg commented 3 years ago

In the future, would that be possible for the upmix plugin to get the format information S16/S32/other (with a default set to S16) from the asoundrc file, allowing the user to change format in a more friendly way than having to patch & recompile ? Thanks for answers :)