search

alsa-project / libhinawa

Mirror of https://git.kernel.org/pub/scm/libs/ieee1394/libhinawa.git for user support and continuous integration. I/O library for IEEE 1394 asynchronous transactions to/from units on the bus, with GObject Introspection.
GNU Lesser General Public License v2.1
7 stars 8 forks source link

[PATCH 0/2] fw_req: obsolete usage of `sync` and `async` suffixes for method #93

Closed takaswie closed 1 year ago

takaswie commented 1 year ago

As issued in #89 , in the convention of GNOME project, the keywords, sync and async, are used to distinguish asynchronous I/O. I misunderstood and misuse them for blocking/non-blocking API in Hinawa.FwReq.

This commit adds an alternative function to deprecate the previous methods. Hinawa.FwReq.request() is newly added to obsolete Hinawa.FwReq.transaction_async(). Hinawa.FwReq.transaction_with_tstamp_sync() is renamed to Hinawa.FwReq.transaction_with_tstamp() and obsoletes Hinawa.FwReq.transaction_sync().

As a result, user space application is encouraged to use Hinawa.FwReq.transaction_with_tstamp(), Hinawa.FwReq.request().

Takashi Sakamoto (2):
  fw_req: remove 'sync' suffix from
    Hinawa.FwReq.transaction_with_tstamp()
  fw_req: add Hinawa.FwReq.request() to obsolete usage of 'async'

 README.rst                 | 10 +++++++--
 samples/common/__init__.py |  2 +-
 src/fw_fcp.c               | 10 ++++-----
 src/fw_req.c               | 45 ++++++++++++++++++++++++++++++++------
 src/fw_req.h               | 12 ++++++----
 src/hinawa.map             |  3 ++-
 tests/fw-req               |  3 ++-
 7 files changed, 64 insertions(+), 21 deletions(-)
takaswie commented 1 year ago

Merged.