alsa-project / snd-firewire-ctl-services

A set of server programs for audio and music units on IEEE 1394 bus supported by Linux sound subsystem a.k.a. ALSA.
GNU General Public License v3.0
35 stars 5 forks source link

[PATCH 00/24] protocols/motu: add traits to parse and update parameters in Command DSP models #165

Closed takaswie closed 1 year ago

takaswie commented 1 year ago

For Command DSP models, current implementation of protocol crate uses several traits and their implementations to parse and update commands for parameters, while it is possible to unify the traits. It is convenient since it is enough to maintain single interface. This patchset is for the purpose.

Takashi Sakamoto (24):
  runtime/motu: refactor for helper function to convert f32/i32 values
  runtime/motu: refactor for helper function to convert u32/i32 values
  runtime/motu: refactor for helper function to handle boolean values
  runtime/motu: refactor for helper function to handle i32 values
  runtime/motu: refactor for helper function to handle enumeration
    values
  protocols/motu: add traits to parse and update parameters according to
    commands
  protocols/motu: implement traits to parse and update reverb effect
    parameters in Command DSP models
  runtime: use trait implementations to parse and update reverb effect
    parameters in Command DSP models
  protocols/motu: implement traits to parse and update monitor
    parameters in Command DSP models
  runtime: use trait implementations to parse and update monitor
    parameters in Command DSP models
  protocols/motu: implement traits to parse and update mixer parameters
    in Command DSP models
  runtime: use trait implementations to parse and update mixer effect
    controls in Command DSP models
  protocols/motu: add trait for specification of equalizer effect in
    Command DSP models
  runtime: use trait implementations to parse and update equalizer
    effect controls in Command DSP models
  protocols/motu: add trait for specification of dynamics effects in
    Command DSP models
  runtime: use trait implementations to parse and update dynamics effect
    controls in Command DSP models
  protocols/motu: implement traits to parse and update input parameters
    in Command DSP models
  runtime: use trait implementations to parse and update input controls
    in Command DSP models
  protocols/motu: implement traits to parse and update output parameters
    in Command DSP models
  runtime: use trait implementations to parse and update output controls
    in Command DSP models
  protocols/motu: implement traits to parse and update meter parameters
    in Command DSP models
  runtime: use trait implementations to parse meter controls in Command
    DSP models
  runtime/motu: cancel traverse when detecting command in Command DSP
    models
  protocols/motu: implement Debug trait to protocols for Command DSP
    models

 protocols/motu/src/command_dsp.rs        | 1437 +++++-----
 protocols/motu/src/version_3.rs          |  108 +-
 runtime/motu/src/command_dsp_ctls.rs     | 3180 ++++++++++------------
 runtime/motu/src/f828mk3.rs              |   16 +-
 runtime/motu/src/f828mk3_hybrid.rs       |   16 +-
 runtime/motu/src/track16.rs              |   16 +-
 runtime/motu/src/traveler_mk3.rs         |   16 +-
 runtime/motu/src/ultralite_mk3.rs        |   16 +-
 runtime/motu/src/ultralite_mk3_hybrid.rs |   16 +-
 9 files changed, 2422 insertions(+), 2399 deletions(-)
takaswie commented 1 year ago

Merged.