alsacreations / KNACSS

feuille de styles CSS sur-vitaminée
http://www.knacss.com
Do What The F*ck You Want To Public License
554 stars 116 forks source link

Knacss-Reborn overwrites my own css #343

Closed CMontaut closed 2 years ago

CMontaut commented 2 years ago

Hi, I'm using Knacks-Reborn with my website which uses .scss. Since I used Knacss-reborn, it overwrites my scss files (for example, I need to print some of my pages with background-color, but _reset-print.scss is the one which is interpreted while it is called before other .scss files). I think that's because it's "called" last but this is not the case in my code. Is there any reasons why it could be called last on losing web pages ?

P.S. : sorry, I can't show you the code because it's quite confidential for my company...

raphaelgoetter commented 2 years ago

Hello !

The KNACSS print stylesheet does indeed run a background: transparent !important; on all elements, which is why this rule overrides all yours.

If you really want to display a custom background color, you can - in your stylesheet, without touching KNACSS - write the CSS like this:

body {background: myColor !important;}

(myColor is to be replaced by your color)

Good luck!

CMontaut commented 2 years ago

Hello, Thank you for your answer. Actually, I did this for some of my specific styles but I would like not to do this for all of my stylesheet. Is it possible to interpret knacss-reborn without overwrite my scss files ?

raphaelgoetter commented 2 years ago

Only the declarations with !important can overwrite your styles so they should be minimal, see https://github.com/alsacreations/KNACSS/blob/master/sass/base/_reset-print.scss#L6

Also, you have to import your own style files after all the imports from KNACSS here : https://github.com/alsacreations/KNACSS/blob/master/sass/knacss.scss

CMontaut commented 2 years ago

Ok, thank you for your answer !