search

alsciende / fiveringsdb-api

Deckbuilder for Legend of the Five Rings (API server)
https://fiveringsdb.com
MIT License
2 stars 4 forks source link

[Rulings] Add rulings to the pop-up window and to search results #34

Closed mplain closed 7 years ago

mplain commented 7 years ago

Currently the rulings are only visible on the individual card pages, and not many people ever get there.

If you could please make rulings aslo show up in the pop-up window when clicking a card title.

Also, if Search gives out only one result, it shows it the same way as an individual card page, with card art and data, but without rulings. Could you please make rulings show up in that case as well? Example: https://fiveringsdb.com/cards/search?q=Calling%20in%20Favors

alsciende commented 7 years ago

No rulings on the popup, but yes to second request.

mplain commented 7 years ago

When at an individual card page, links from the Rulings section lead to https://fiveringsdb.com/card/ and function correctly.

When at a Search result page showing only one card, links from the Rulings section lead to https://fiveringsdb.com/cardS/ and lead to Page Not Found.

1 2

alsciende commented 7 years ago

Don't use this way of linking. Use an absolute url.

alsciende commented 7 years ago

Also, don't piggy-back on existing issues. Create new ones for new problems, other I can't track them correctly.