alshedivat / al-folio

A beautiful, simple, clean, and responsive Jekyll theme for academics
https://alshedivat.github.io/al-folio/
MIT License
11.19k stars 11.24k forks source link

Incorrectly handling last names with more than one word #110

Closed mvdoc closed 4 years ago

mvdoc commented 4 years ago

Acknowledge the following

Describe the bug Hi, first of all, thanks for making & sharing this awesome theme. I'm excited to use it for my own website.

I think that the changes introduced by #102 do not correctly parse last names with more than one word (like mine, made up by four words). Clearly, there is no general way to automatically parse a name into first, middle, last name in a way that generalizes to all possible names. I would think that adding explicit variables in the config file would solve the issue.

This is the first time I'm using jekyll, but I will address this issue (because I really want to use this theme!). It will take me a while most likely, but I'm happy to submit a PR when I solve it.

EDIT

Short example showing the problem. Changing the name in _config.yml to "You R. Long Last Name" renders as follows

image

alshedivat commented 4 years ago

Thanks for pointing this out! Agreed, having separate variables for the first and last names (and an optional variable for the middle name) should work much better than parsing. It would be great if you can address this issue. Thanks!