search

alshedivat / al-folio

A beautiful, simple, clean, and responsive Jekyll theme for academics
https://alshedivat.github.io/al-folio/
MIT License
10.55k stars 10.94k forks source link

New arXiv favicon #1704

Closed ninyam closed 11 months ago

ninyam commented 1 year ago

Hi there!

This is not really an issue. I want my site to display the new arXiv favicon [https://jpswalsh.github.io/academicons/].

But I don't know how to modify the settings to make this possible.

Thanks a lot for your help!

george-gca commented 1 year ago

If the icon is already showing somewhere, but it is just not the updated one, all you need to do is update the version of academicon used in _config.yml

ninyam commented 1 year ago

Thank you! I just changed it the 1.9.1 to 1.9.4. However, it didn't work. I had ORCID, Scopus and arXiv academicons showing with 1.9.1, but when I changed the version they disappeared.

Is this because I also need to change the integrity below version?

Thank you!

george-gca commented 1 year ago

Yes, you also have to update the integrity. The integrity is the hash of the file. With the wrong integrity the file will not load at all.

TheFermi0n commented 1 year ago

As you can see here, the latest academicons npm package is 1.9.2 and not the 1.9.4. So you will not be able to get an integrity for 1.9.4.

For 1.9.2 the integrity is "sha256-CylD++oS3IkJmSs/j4i1w0cv2wpVQRLLQqw/m+Fvxts=". I used the SRI Hash Generator

But, the new arXiv icon isn't there as well.

I have tested the 1.9.4 locally by manually installing.

I don't know how much this will hamper the site speed. @george-gca Is it good to install the fonts locally or call from the cdn?

george-gca commented 1 year ago

Apparently it's been a while since the npm package was updated. Also there are still missing icons from academicons that could be added (I created a feature request for one a while ago). One day I will create a PR for this.

According to this site, it would be better to load things from CDN since it can load from sources closer to the user. At the same time, loading locally can offer other benefits when used with some other solutions like this one here. I will try to do some more thorough tests with the purgecss solution, then maybe include it with locally loaded academicons too.

george-gca commented 1 year ago

EDIT: I just realized that I did include academicons in the solution with purgecss already. I will try to find some time on the weekend to see this through.

I would for now recommend locally loading the academicons package if you want the latest version. If someone could send a PR for this would be great.

george-gca commented 11 months ago

I believe this was fixed in #1562